Skip to content

Commit 5ea9a26

Browse files
projectgusdpgeorge
authored andcommitted
esp32: Don't disable component manager when updating submodules.
- Reverts the change from ec527a1 - since later change cccac2c we no longer exit CMake early to get the submodule list, so it's OK to run component manager during this phase. - Fixes issue where "make submodules BOARD=ESP32_GENERIC_S3" (or any other board that depends on USB) would fail due to missing component(s). This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <[email protected]>
1 parent a94f811 commit 5ea9a26

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ports/esp32/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,4 +112,4 @@ size-files:
112112
# This is done in a dedicated build directory as some CMake cache values are not
113113
# set correctly if not all submodules are loaded yet.
114114
submodules:
115-
$(Q)IDF_COMPONENT_MANAGER=0 idf.py $(IDFPY_FLAGS) -B $(BUILD)/submodules -D UPDATE_SUBMODULES=1 reconfigure
115+
$(Q)idf.py $(IDFPY_FLAGS) -B $(BUILD)/submodules -D UPDATE_SUBMODULES=1 reconfigure

0 commit comments

Comments
 (0)