new preinstall task fails

[ahjohannessen]

After bumping version from v3.1.2 to v3.2.0 I get this:

TASK [ansible-vault : Update package cache] ***************************************************************************************************************************************************************************************************************************************************************************
task path: /Users/ahjohannessen/Development/Work/devops/ansible-libs/ansible-vault/tasks/preinstall.yml:21
redirecting (type: modules) ansible.builtin.atomic_container to community.general.atomic_container
[DEPRECATION WARNING]: community.general.atomic_container has been deprecated. Poject Atomic was sunset by the end of 2019. This feature will be removed from community.general in version 13.0.0. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
redirecting (type: modules) ansible.builtin.atomic_container to community.general.atomic_container
redirecting (type: modules) ansible.builtin.atomic_container to community.general.atomic_container
redirecting (type: modules) ansible.builtin.atomic_container to community.general.atomic_container
redirecting (type: modules) ansible.builtin.atomic_container to community.general.atomic_container
redirecting (type: modules) ansible.builtin.atomic_container to community.general.atomic_container
redirecting (type: modules) ansible.builtin.atomic_container to community.general.atomic_container
redirecting (type: modules) ansible.builtin.atomic_container to community.general.atomic_container
redirecting (type: modules) ansible.builtin.atomic_container to community.general.atomic_container
fatal: [192.168.81.101]: FAILED! => {"changed": false, "msg": "missing required arguments: backend, image, name"}
fatal: [192.168.81.102]: FAILED! => {"changed": false, "msg": "missing required arguments: backend, image, name"}
fatal: [192.168.81.100]: FAILED! => {"changed": false, "msg": "missing required arguments: backend, image, name"}

[ahjohannessen]

ping @lakrass

The task does not fail If the following in preinstall is removed:

 - name: Update package cache
   ansible.builtin.package:
     update_cache: true
   tags: update_cache

The reason for this is that I use Fedora CoreOS in my staging env. ("msg": "atomic_container"). The same is going to happen for Flatcar Linux.

A fix is adding a condition:

# in defaults:
  is_fedora_coreos: false
...
...
  when:
    - not is_fedora_coreos
    - not ansible_os_family in ["Flatcar", "Flatcar Container Linux by Kinvolk"]

or a more general thing:

--
is_container_based_os: false

and

  when:
    - not is_container_based_os

or similar.

[lakrass]

I'm not sure exactly about the behaviour of atomic containers. As far as I know them, they are immutable?
As hotfix you can add --skip-tags update_cache to your ansible command prompt for now.

We are currently thinking of disabling the cache update by default.

[ahjohannessen]

I added a workaround for Flatcar years ago: 78a9dab

vault_os_packages: []

was the key to get that working.

[ahjohannessen]

I'm not sure exactly about the behaviour of atomic containers. As far as I know them, they are immutable?

Yes. Well, distros like Flatcar / Fedora CoreOS are not like the usual ones.

As hotfix you can add --skip-tags update_cache to your ansible command prompt for now.

We are currently thinking of disabling the cache update by default.

update_package_cache: true

Then one can workaround that with setting that to false.

[lakrass]

Ok, I understand the situation here.

We will add a molecule test for Fedora CoreOS and figure out a suitable solution! I will take your ideas and recommendations into account :)

Thank you!

[ahjohannessen]

For Fedora CoreOS I see kubespray did somthing like:

- name: check if booted with ostree
  stat:
    path: /run/ostree-booted
  register: ostree

- name: set is_fedora_coreos
  lineinfile:
    path: /etc/os-release
    line: "VARIANT_ID=coreos"
    state: present
  check_mode: yes
  register: os_variant_coreos
  changed_when: false

- name: set is_fedora_coreos
  set_fact:
    is_fedora_coreos: "{{ ostree.stat.exists and os_variant_coreos is not changed }}"

Today, it seems kubespray "natively" bootstraps for Fedora CoreOS, so that fact setting is not used anymore. However, that is a solid way, however perhaps a bit too "one-off".