fix: ruff, mypy and pylint violations

Fixes: #2039

Author: ssbarnea

.pre-commit-config.yaml

@@ -15,7 +15,7 @@ exclude: >
   )$
 repos:
   - repo: https://github.com/renovatebot/pre-commit-hooks
-    rev: 41.99.7
+    rev: 41.113.0
     hooks:
       - id: renovate-config-validator
         alias: renovate
@@ -54,29 +54,12 @@ repos:
     rev: 1.6.0
     hooks:
       - id: tox-ini-fmt
-
-  - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: "v0.12.12"
-    hooks:
-      - id: ruff
-        entry: sh -c 'ruff check --fix --force-exclude && ruff format --force-exclude'
-        types_or: [python, pyi]
-
   - repo: https://github.com/streetsidesoftware/cspell-cli
     rev: v9.2.0
     hooks:
       - id: cspell
         name: Spell check with cspell
 
-  - repo: https://github.com/Lucas-C/pre-commit-hooks.git
-    rev: v1.5.5
-    hooks:
-      - id: remove-tabs
-        exclude: >
-          (?x)^(
-            .config/pylint-baseline.txt
-          )$
-
   - repo: https://github.com/pre-commit/pre-commit-hooks.git
     rev: v6.0.0
     hooks:
@@ -168,8 +151,15 @@ repos:
     hooks:
       - id: pyupgrade
         args: ["--py310-plus"]
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.12.11
+    hooks:
+      - id: ruff-format
+        alias: ruff
+      - id: ruff-check
+        alias: ruff
   - repo: https://github.com/pre-commit/mirrors-mypy.git
-    rev: v1.17.1
+    rev: v1.18.1
     hooks:
       - id: mypy
         additional_dependencies:

pyproject.toml

@@ -122,6 +122,7 @@ disable = [
   "too-few-public-methods",
   "unsubscriptable-object",
   "unknown-option-value",
+  "CPY001", # copyright notice at top of file
   # https://gist.github.com/cidrblock/ec3412bacfeb34dbc2d334c1d53bef83
   "C0103", # invalid-name / ruff N815
   "C0105", # typevar-name-incorrect-variance / ruff PLC0105
@@ -371,6 +372,7 @@ builtins = ["__"]
 exclude = ["tests/fixtures/**", ".git"]
 fix = true
 line-length = 100
+unsafe-fixes = true
 
 [tool.ruff.lint]
 ignore = [

src/ansible_navigator/tm_tokenize/fchainmap.py

@@ -8,8 +8,8 @@
 TValue_co = TypeVar("TValue_co", covariant=True)
 
 
-class Indexable(Generic[TKey_contra, TValue_co], Protocol):
-    def __getitem__(self, key: TKey_contra) -> TValue_co:
+class Indexable(Protocol[TKey_contra, TValue_co]):
+    def __getitem__(self, key: TKey_contra) -> TValue_co:  # type: ignore
         """Get the value associated with the given key.
 
         Args:

src/ansible_navigator/utils/compatibility.py

@@ -9,7 +9,7 @@
 
 
 if sys.version_info < (3, 11):
-    from importlib.abc import Traversable
+    from importlib.abc import Traversable  # pylint: disable=deprecated-class
 else:
     from importlib.resources.abc import Traversable
 

src/ansible_navigator/utils/json_schema.py

@@ -4,6 +4,7 @@
 
 import json
 
+from collections import deque
 from dataclasses import dataclass
 from typing import TYPE_CHECKING
 from typing import Any
@@ -16,10 +17,10 @@
 
 
 if TYPE_CHECKING:
-    from collections import deque
+    from collections.abc import Sequence
 
 
-def to_path(schema_path: deque[Any]) -> str:
+def to_path(schema_path: Sequence[Any] | str) -> str:
     """Flatten a path to a dot delimited string.
 
     Args:
@@ -28,10 +29,11 @@ def to_path(schema_path: deque[Any]) -> str:
     Returns:
         The dot delimited path
     """
-    return ".".join(str(index) for index in schema_path)
+    queue = schema_path if isinstance(schema_path, deque) else deque(schema_path)
+    return ".".join(str(index) for index in queue)
 
 
-def json_path(absolute_path: deque[Any]) -> str:
+def json_path(absolute_path: Sequence[Any]) -> str:
     """Flatten a data path to a dot delimited string.
 
     Args:
@@ -97,7 +99,7 @@ def validate(schema: str | dict[str, Any], data: dict[str, Any]) -> list[JsonSch
 
     if isinstance(schema, str):
         schema = json.loads(schema)
-    if isinstance(schema, bool):
+    if isinstance(schema, (bool, str)):
         msg = "Unexpected schema data."
         raise TypeError(msg)
     validator = validator_for(schema)
@@ -129,10 +131,10 @@ def validate(schema: str | dict[str, Any], data: dict[str, Any]) -> list[JsonSch
                 data_path=to_path(validation_error.absolute_path),
                 json_path=json_path(validation_error.absolute_path),
                 schema_path=to_path(validation_error.relative_schema_path),
-                relative_schema=validation_error.schema,
-                expected=validation_error.validator_value,
-                validator=validation_error.validator,
-                found=validation_error.instance,
+                relative_schema=str(validation_error.schema),
+                expected=str(validation_error.validator_value),
+                validator=str(validation_error.validator),
+                found=str(validation_error.instance),
             )
             errors.append(error)
     return errors

tests/integration/_common.py

@@ -248,7 +248,7 @@ def copytree(
         try:
             if symlinks and source_path.is_symlink():
                 source_link = source_path.readlink()
-                os.symlink(source_link, destination_path)
+                source_link.symlink_to(destination_path)
             elif source_path.is_dir():
                 copytree(
                     source_path,