Skip to content

Commit b3f2b6c

Browse files
[#85738] server: Fix file download
The PartNumber in multipart upload was off by one. Minio was accepting such requests fine, but aws was returning errors
1 parent db8ad61 commit b3f2b6c

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

server/src/storage/s3.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ def generate_urls(self, upload_size: int, expiry: int) -> tuple[list[str], int]:
173173
Params={
174174
"Bucket": self.s3.bucket,
175175
"Key": self.key,
176-
"PartNumber": i,
176+
"PartNumber": i + 1,
177177
"UploadId": self.mpu["UploadId"]
178178
},
179179
ExpiresIn=expiry,
@@ -190,7 +190,9 @@ def complete_upload(self, etags: list[str]):
190190
Bucket=self.s3.bucket,
191191
Key=self.key,
192192
MultipartUpload={
193-
'Parts': [{"ETag": etag, "PartNumber": idx} for idx, etag in enumerate(etags)]
193+
'Parts': [
194+
{"ETag": etag, "PartNumber": idx + 1} for idx, etag in enumerate(etags)
195+
]
194196
},
195197
UploadId=self.mpu["UploadId"]
196198
)

0 commit comments

Comments
 (0)