Skip to content

has-float-label class apply on all labels #21

@NicosKaralis

Description

@NicosKaralis

This code worked fine in version 1.0.0, now in version 1.0.2 it breaks

<div class="col-xs-12">
  <div class="form-group has-float-label">
    <input type="text" name="username" id="username" class="form-control" placeholder=" ">
    <label class="control-label" for="username">Username</label>
    <span class="help-block"> Help message </span>
  </div>
</div>

Aparently, this change scss/_mixins.scss#L6 made all spans inside a .has-float-label element become a float label, when it shouldn't

Can someone explain to me why this change was made? And why it was needed?

In my application we have a lot of fields, all of them using float label. We had been using v1.0.0, but a new dependency made v1.0.2 required and this bug appeared.

I know I can change the spans to p but how could I solve this without messing with the current HTML?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions