Fix faulty migration

core/anytype/bootstrap.go

@@ -48,6 +48,7 @@ import (
 	"github.com/anyproto/anytype-heart/core/block/detailservice"
 	"github.com/anyproto/anytype-heart/core/block/editor"
 	"github.com/anyproto/anytype-heart/core/block/editor/converter"
+	"github.com/anyproto/anytype-heart/core/block/editor/widgetmigration"
 	"github.com/anyproto/anytype-heart/core/block/export"
 	importer "github.com/anyproto/anytype-heart/core/block/import"
 	"github.com/anyproto/anytype-heart/core/block/object/idderiver/idderiverimpl"
@@ -334,6 +335,7 @@ func Bootstrap(a *app.App, components ...app.Component) {
 		Register(api.New()).
 		Register(pushclient.New()).
 		Register(pushnotification.New()).
+		Register(widgetmigration.New()).
 		Register(durability.New()) // leave it the last one
 }
 

core/block/delete.go

@@ -36,10 +36,10 @@ func (s *Service) DeleteObjectByFullID(id domain.FullID) error {
 		return err
 	}
 
-	entry, err := spc.Storage().HeadStorage().GetEntry(s.componentCtx, id.ObjectID)
-	if err != nil {
-		return fmt.Errorf("get head entry: %w", err)
-	}
+	// entry, err := spc.Storage().HeadStorage().GetEntry(s.componentCtx, id.ObjectID)
+	// if err != nil {
+	// 	return fmt.Errorf("get head entry: %w", err)
+	// }
 
 	switch sbType {
 	case coresb.SmartBlockTypeObjectType,
@@ -56,11 +56,11 @@ func (s *Service) DeleteObjectByFullID(id domain.FullID) error {
 		}
 		err = spc.DeleteTree(context.Background(), id.ObjectID)
 	default:
-		if entry.IsDerived {
-			err = s.deleteDerivedObject(id, sbType, spc)
-		} else {
-			err = spc.DeleteTree(context.Background(), id.ObjectID)
-		}
+		// if entry.IsDerived {
+		// 	err = s.deleteDerivedObject(id, sbType, spc)
+		// } else {
+		err = spc.DeleteTree(context.Background(), id.ObjectID)
+		// }
 	}
 	if err != nil {
 		return err

core/block/editor/factory.go

@@ -89,6 +89,7 @@ type ObjectFactory struct {
 	statService             debugstat.StatService
 	backlinksUpdater        backlinks.UpdateWatcher
 	formatFetcher           relationutils.RelationFormatFetcher
+	fixer                   fixer
 }
 
 func NewObjectFactory() *ObjectFactory {
@@ -129,6 +130,7 @@ func (f *ObjectFactory) Init(a *app.App) (err error) {
 		f.statService = debugstat.NewNoOp()
 	}
 	f.formatFetcher = app.MustComponent[relationutils.RelationFormatFetcher](a)
+	f.fixer = app.MustComponent[fixer](a)
 	return nil
 }
 

core/block/editor/page.go

@@ -251,6 +251,7 @@ func (p *Page) CreationStateMigration(ctx *smartblock.InitContext) migration.Mig
 			case model.ObjectType_collection:
 				blockContent := template.MakeDataviewContent(true, nil, nil, nil)
 				templates = append(templates,
+					template.WithTitle,
 					template.WithDataview(blockContent, false),
 				)
 			default:

core/block/editor/widget.go

@@ -28,6 +28,12 @@ type WidgetObject struct {
 	basic.Updatable
 	widget.Widget
 	basic.DetailsSettable
+
+	fixer fixer
+}
+
+type fixer interface {
+	DeleteGarbage(spaceId string) error
 }
 
 func (f *ObjectFactory) newWidgetObject(
@@ -42,6 +48,7 @@ func (f *ObjectFactory) newWidgetObject(
 		DetailsSettable: bs,
 		IHistory:        basic.NewHistory(sb),
 		Widget:          widget.NewWidget(sb),
+		fixer:           f.fixer,
 	}
 }
 
@@ -87,6 +94,13 @@ func (w *WidgetObject) Init(ctx *smartblock.InitContext) (err error) {
 		ctx.State.Unlink(id)
 	}
 
+	go func() {
+		derr := w.fixer.DeleteGarbage(w.SpaceID())
+		if derr != nil {
+			log.Errorf("widget: delete garbage: %v", derr)
+		}
+	}()
+
 	return nil
 }
 

core/block/editor/widgetmigration/service.go

@@ -0,0 +1,131 @@
+package widgetmigration
+
+import (
+	"context"
+	"fmt"
+
+	"github.com/anyproto/any-sync/app"
+
+	"github.com/anyproto/anytype-heart/core/block/cache"
+	"github.com/anyproto/anytype-heart/core/block/editor/smartblock"
+	"github.com/anyproto/anytype-heart/core/block/object/objectcreator"
+	"github.com/anyproto/anytype-heart/core/domain"
+	coresb "github.com/anyproto/anytype-heart/pkg/lib/core/smartblock"
+	"github.com/anyproto/anytype-heart/pkg/lib/localstore/objectstore"
+	"github.com/anyproto/anytype-heart/pkg/lib/logging"
+	"github.com/anyproto/anytype-heart/space"
+)
+
+const CName = "core.block.editor.widgetmigration"
+
+const internalKeyRecentlyEdited = "recently_edited"
+const internalKeyRecentlyOpened = "recently_opened"
+const internalKeyOldPinned = "old_pinned"
+
+var log = logging.Logger(CName)
+
+type Service interface {
+	app.ComponentRunnable
+
+	MigrateWidgets(objectId string) error
+	AddToOldPinnedCollection(space smartblock.Space, favoriteIds []string) error
+	DeleteGarbage(spaceId string) error
+}
+
+type deleter interface {
+	DeleteObjectByFullID(id domain.FullID) error
+}
+
+type service struct {
+	componentCtx       context.Context
+	componentCtxCancel context.CancelFunc
+
+	objectGetter  cache.ObjectGetter
+	objectCreator objectcreator.Service
+	spaceService  space.Service
+	objectStore   objectstore.ObjectStore
+	deleter       deleter
+}
+
+func New() Service {
+	return &service{}
+
+}
+
+func (s *service) Name() string {
+	return CName
+}
+
+func (s *service) Run(ctx context.Context) error {
+	return nil
+}
+
+func (s *service) Close(ctx context.Context) error {
+	if s.componentCtxCancel != nil {
+		s.componentCtxCancel()
+	}
+	return nil
+}
+
+func (s *service) Init(a *app.App) error {
+	s.componentCtx, s.componentCtxCancel = context.WithCancel(context.Background())
+
+	s.objectGetter = app.MustComponent[cache.ObjectGetter](a)
+	s.objectCreator = app.MustComponent[objectcreator.Service](a)
+	s.spaceService = app.MustComponent[space.Service](a)
+	s.objectStore = app.MustComponent[objectstore.ObjectStore](a)
+	s.deleter = app.MustComponent[deleter](a)
+	return nil
+}
+
+func (s *service) DeleteGarbage(spaceId string) error {
+	spc, err := s.spaceService.Get(s.componentCtx, spaceId)
+	if err != nil {
+		return fmt.Errorf("get space: %w", err)
+	}
+
+	for _, cs := range []struct {
+		uk domain.UniqueKey
+	}{
+		{
+			uk: domain.MustUniqueKey(coresb.SmartBlockTypePage, internalKeyOldPinned),
+		},
+		{
+			uk: domain.MustUniqueKey(coresb.SmartBlockTypePage, internalKeyRecentlyOpened),
+		},
+		{
+			uk: domain.MustUniqueKey(coresb.SmartBlockTypePage, internalKeyRecentlyEdited),
+		},
+	} {
+		go func() {
+			id, err := spc.DeriveObjectID(s.componentCtx, cs.uk)
+			if err != nil {
+				fmt.Println("DERIVE OBJECT ID", err)
+				return
+			}
+
+			err = s.deleter.DeleteObjectByFullID(domain.FullID{
+				ObjectID: id,
+				SpaceID:  spaceId,
+			})
+			if err != nil {
+				fmt.Println("DELETE OBJECT", err)
+				return
+			}
+			fmt.Println("DELETED", id, cs.uk.InternalKey(), id)
+		}()
+	}
+	return nil
+}
+
+func (s *service) MigrateWidgets(objectId string) error {
+	return nil
+}
+
+func (s *service) AddToOldPinnedCollection(space smartblock.Space, favoriteIds []string) error {
+	return nil
+}
+
+func (s *service) addToMigratedCollection(space smartblock.Space, collId string, favoriteIds []string) error {
+	return nil
+}