IOS-5521 Implement Demo 1-1 Spaces #4307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add feature flag demoOneToOneSpaces to enable 1-1 space creation - Add Connect button to ProfileView for creating 1-1 spaces - Extend SpaceUxType with oneToOne case and isOneToOne helper - Update WorkspaceService with createOneToOneSpace method - Remove redundant ConversationType enum, use SpaceUxType directly - Update chat views to use spaceUxType instead of conversationType - Add localization for "Connect" and "Private channel" strings - Update space icon logic to use supportsMultiChats for circular icons - Document AsyncStandardButton pattern in ios-dev-guidelines skill
Contributor
|
✅ Approved - No issues found |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
demoOneToOneSpacesto enable 1-1 space creation from profile modal.oneToOnecase - behaves like chat (first screen is chat, circular icon)ConversationTypeenum, useSpaceUxTypedirectly in chat viewsAsyncStandardButtonpattern in ios-dev-guidelines skill