Skip to content

Conversation

@ignatovv
Copy link
Member

@ignatovv ignatovv commented Dec 4, 2025

Summary

  • Wait for chat message previews before showing spaces to prevent jumping on first load
  • Disable animations when Space Hub is off-screen so returning shows spaces in correct order without animation

@ignatovv ignatovv requested a review from a team as a code owner December 4, 2025 14:13
@claude
Copy link
Contributor

claude bot commented Dec 4, 2025

Best Practices

SpaceHubList.swift:35
Wrapping in DispatchQueue.main.async is unnecessary since SwiftUI views are already @mainactor. This should be:

.onAppear { model.animationsEnabled = true }

The flag will still be set on the main thread, but synchronously during the appear lifecycle event.


⚠️ Minor Issues - Remove unnecessary DispatchQueue.main.async wrapper

@ignatovv ignatovv merged commit 9f26ade into develop Dec 4, 2025
8 checks passed
@ignatovv ignatovv deleted the ios-5566--lets-not-animate-1st-appearance-on-space-hub branch December 4, 2025 14:45
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants