Skip to content

Conversation

@al1img
Copy link
Collaborator

@al1img al1img commented Aug 13, 2025

No description provided.

@al1img al1img force-pushed the update_protocol branch 3 times, most recently from a7e0a7c to 880be33 Compare August 18, 2025 15:39
Copy link

@MykolaSuperman MykolaSuperman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Mykola Solianko <[email protected]>

Copy link
Member

@mlohvynenko mlohvynenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Mykhailo Lohvynenko <[email protected]>

al1img added 13 commits August 20, 2025 15:02
Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
* rename cloudmessage.hpp to protocol.hpp;
* move message type enum to protocol.hpp.

Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Renamed to match cloud protocol naming.

Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
cloudprotocol::NodeConfig is changed and not compatible with current
resourcemanger implementation. resourcemanger should be reimplemented but to
make it compile and to do not break unit tests, use own NodeConfig struct for
now.

Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Move AOS_CONFIG_NETWORKMANAGER_CONNECTIONS_PER_INSTANCE_MAX_COUNT to CM config.

Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 87.23404% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.17%. Comparing base (da33592) to head (33691c3).
⚠️ Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
src/core/common/monitoring/tests/monitoring.cpp 70.00% 3 Missing ⚠️
src/core/iam/tests/mocks/nodeinfoprovidermock.hpp 0.00% 3 Missing ⚠️
src/core/common/cloudprotocol/desiredstatus.hpp 0.00% 2 Missing ⚠️
src/core/common/monitoring/resourcemonitor.cpp 75.00% 1 Missing ⚠️
src/core/common/ocispec/runtimespec.hpp 0.00% 1 Missing ⚠️
src/core/iam/nodemanager/nodemanager.cpp 83.33% 1 Missing ⚠️
src/core/sm/tests/mocks/resourcemanagermock.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #350      +/-   ##
===========================================
- Coverage    82.18%   82.17%   -0.01%     
===========================================
  Files          171      171              
  Lines        17039    17035       -4     
  Branches      2316     2316              
===========================================
- Hits         14003    13999       -4     
  Misses        3036     3036              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

@al1img al1img merged commit 0d20af5 into aosedge:develop Aug 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants