GH-48174: [CI][Dev] Fix shellcheck errors in ci/scripts/util_download_apache.sh

Author: hiroyuki-sato

.pre-commit-config.yaml

@@ -341,6 +341,7 @@ repos:
           ?^ci/scripts/release_test\.sh$|
           ?^ci/scripts/ruby_test\.sh$|
           ?^ci/scripts/rust_build\.sh$|
+          ?^ci/scripts/util_download_apache\.sh$|
           ?^ci/scripts/util_enable_core_dumps\.sh$|
           ?^ci/scripts/util_free_space\.sh$|
           ?^ci/scripts/util_log\.sh$|

ci/scripts/util_download_apache.sh

@@ -44,10 +44,9 @@ APACHE_MIRRORS=(
 
 mkdir -p "${target_dir}"
 
-for mirror in ${APACHE_MIRRORS[*]}
+for mirror in "${APACHE_MIRRORS[@]}"
 do
-  curl -SL "${mirror}/${tarball_path}" | tar -xzf - -C "${target_dir}"
-  if [ $? == 0 ]; then
+  if curl -SL "${mirror}/${tarball_path}" | tar -xzf - -C "${target_dir}"; then
     exit 0
   fi
 done