Skip to content

Commit 91e50dd

Browse files
committed
Refactoring
1 parent b91b1da commit 91e50dd

File tree

2 files changed

+31
-4
lines changed

2 files changed

+31
-4
lines changed

.github/workflows/beam_PostCommit_XVR_GoUsingJava_Dataflow.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,9 @@ jobs:
7777
python-version: default
7878
- name: Set up Docker Buildx
7979
uses: docker/setup-buildx-action@v3
80-
- name: GCloud Docker credential helper
81-
run: |
82-
gcloud auth configure-docker us.gcr.io
8380
- name: run XVR GoUsingJava Dataflow script
8481
env:
8582
USER: github-actions
86-
CLOUDSDK_CONFIG: ${{ env.KUBELET_GCLOUD_CONFIG_PATH}}
8783
uses: ./.github/actions/gradle-command-self-hosted-action
8884
with:
8985
gradle-command: :runners:google-cloud-dataflow-java:validatesCrossLanguageRunnerGoUsingJava

runners/google-cloud-dataflow-java/build.gradle

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -371,11 +371,42 @@ def buildAndPushDockerPythonContainer = tasks.create("buildAndPushDockerPythonCo
371371
name: "${project.docker_image_default_repo_prefix}python${pythonVer}_sdk",
372372
root: "apache",
373373
tag: project.sdk_version)
374+
doFirst {
375+
def cloudsdkConfig = System.getenv("CLOUDSDK_CONFIG")
376+
if (cloudsdkConfig == null || !new File(cloudsdkConfig).canWrite()) {
377+
def tmpGcloudDir = new File("/tmp/gcloud")
378+
tmpGcloudDir.mkdirs()
379+
System.setProperty("CLOUDSDK_CONFIG", "/tmp/gcloud")
380+
exec {
381+
environment "CLOUDSDK_CONFIG", "/tmp/gcloud"
382+
commandLine "gcloud", "--quiet", "auth", "configure-docker", "us.gcr.io"
383+
ignoreExitValue = false
384+
}
385+
exec {
386+
environment "CLOUDSDK_CONFIG", "/tmp/gcloud"
387+
commandLine "gcloud", "--quiet", "auth", "configure-docker", "gcr.io"
388+
ignoreExitValue = false
389+
}
390+
} else {
391+
exec {
392+
environment "CLOUDSDK_CONFIG", cloudsdkConfig
393+
commandLine "gcloud", "--quiet", "auth", "configure-docker", "us.gcr.io"
394+
ignoreExitValue = false
395+
}
396+
exec {
397+
environment "CLOUDSDK_CONFIG", cloudsdkConfig
398+
commandLine "gcloud", "--quiet", "auth", "configure-docker", "gcr.io"
399+
ignoreExitValue = false
400+
}
401+
}
402+
}
374403
doLast {
375404
exec {
376405
commandLine "docker", "tag", "${defaultDockerImageName}", "${dockerPythonImageName}"
377406
}
407+
def cloudsdkConfig = System.getenv("CLOUDSDK_CONFIG") ?: System.getProperty("CLOUDSDK_CONFIG") ?: "/tmp/gcloud"
378408
exec {
409+
environment "CLOUDSDK_CONFIG", cloudsdkConfig
379410
commandLine "gcloud", "docker", "--", "push", "${dockerPythonImageName}"
380411
}
381412
}

0 commit comments

Comments
 (0)