Skip to content

Adds proto fields for overwriting fetch/write state functionality #36708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2025
+9 −0
Merged

Adds proto fields for overwriting fetch/write state functionality #36708

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f65ec40
Adds proto fields for overwriting fetch/write state functionality
wolfchris-google Nov 3, 2025
95a669b
Adds fields to ProcessBundleRequest to prepare for future SDK skips f…
wolfchris-google Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,15 @@ message ProcessBundleRequest {
// beam:protocol:control_request_elements_embedding:v1 capability. See more
// at https://s.apache.org/beam-fn-api-control-data-embedding.
Elements elements = 3;

// indicates that the runner has no start for the keys in this bundle
Copy link
Member

@kennknowles kennknowles Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: s/start/state/

Copy link
Contributor Author

@wolfchris-google wolfchris-google Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thank you! Fixed!

// so SDk can safely begin stateful processing with a locally-generated
// initial empty state
bool has_no_keyed_state = 4;
Copy link
Member

@kennknowles kennknowles Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, "keyed state" is a windmill concept and we just call it "state" or whatnot in Beam. And also it is key+window state. This can just be has_no_state.

Copy link
Contributor Author

@wolfchris-google wolfchris-google Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!


// indicates that the runner will never process another bundle for the keys
// in this bundle so state need not be included in the bundle commit.
bool only_bundle_for_keys = 5;
}

message ProcessBundleResponse {
Expand Down
Loading