code improvements

Author: sureshanaparti

api/src/main/java/org/apache/cloudstack/api/ApiServerService.java

@@ -49,5 +49,5 @@ public ResponseObject loginUser(HttpSession session, String username, String pas
 
     boolean resetPassword(UserAccount userAccount, String token, String password);
 
-    boolean isEnforcePostRequestsAndTimestamps();
+    boolean isPostRequestsAndTimestampsEnforced();
 }

server/src/main/java/com/cloud/api/ApiServer.java

@@ -198,7 +198,7 @@ public class ApiServer extends ManagerBase implements HttpRequestHandler, ApiSer
     private static final String SANITIZATION_REGEX = "[\n\r]";
 
     private static boolean encodeApiResponse = false;
-    private boolean isEnforcePostRequestsAndTimestamps = false;
+    private boolean isPostRequestsAndTimestampsEnforced = false;
 
     /**
      * Non-printable ASCII characters - numbers 0 to 31 and 127 decimal
@@ -282,9 +282,9 @@ public class ApiServer extends ManagerBase implements HttpRequestHandler, ApiSer
             , ConfigKey.Scope.Global);
     static final ConfigKey<Boolean> EnforcePostRequestsAndTimestamps = new ConfigKey<>(ConfigKey.CATEGORY_ADVANCED
             , Boolean.class
-            , "enable.enforce.post.requests.and.timestamps"
+            , "enforce.post.requests.and.timestamps"
             , "false"
-            , "enables/disables whether the ApiServer only accepts state-changing POST requests and requests with timestamps."
+            , "Enable/Disable whether the ApiServer should only accept POST requests for state-changing APIs and requests with timestamps."
             , false
             , ConfigKey.Scope.Global);
     private static final ConfigKey<String> JSONDefaultContentType = new ConfigKey<> (ConfigKey.CATEGORY_ADVANCED
@@ -444,7 +444,7 @@ protected void setupIntegrationPortListener(Integer apiPort) {
     public boolean start() {
         Security.addProvider(new BouncyCastleProvider());
         Integer apiPort = IntegrationAPIPort.value(); // api port, null by default
-        isEnforcePostRequestsAndTimestamps = EnforcePostRequestsAndTimestamps.value();
+        isPostRequestsAndTimestampsEnforced = EnforcePostRequestsAndTimestamps.value();
 
         final Long snapshotLimit = ConcurrentSnapshotsThresholdPerHost.value();
         if (snapshotLimit == null || snapshotLimit <= 0) {
@@ -726,8 +726,8 @@ public String handleRequest(final Map params, final String responseType, final S
     }
 
     @Override
-    public boolean isEnforcePostRequestsAndTimestamps() {
-        return isEnforcePostRequestsAndTimestamps;
+    public boolean isPostRequestsAndTimestampsEnforced() {
+        return isPostRequestsAndTimestampsEnforced;
     }
 
     private String getBaseAsyncResponse(final long jobId, final BaseAsyncCmd cmd) {
@@ -1029,13 +1029,13 @@ public boolean verifyRequest(final Map<String, Object[]> requestParameters, fina
                     apiKey = apiKey.replaceAll(SANITIZATION_REGEX, "_");
                     logger.debug("Request expired -- ignoring ...sig [{}], apiKey [{}].", signature, apiKey);
                     return false;
-                } else if (isEnforcePostRequestsAndTimestamps && expiresTS.after(thresholdTime)) {
+                } else if (isPostRequestsAndTimestampsEnforced && expiresTS.after(thresholdTime)) {
                     signature = signature.replaceAll(SANITIZATION_REGEX, "_");
                     apiKey = apiKey.replaceAll(SANITIZATION_REGEX, "_");
                     logger.debug(String.format("Expiration parameter is set for too long -- ignoring ...sig [%s], apiKey [%s].", signature, apiKey));
                     return false;
                 }
-            } else if (isEnforcePostRequestsAndTimestamps) {
+            } else if (isPostRequestsAndTimestampsEnforced) {
                 // Force expiration parameter
                 logger.debug("Signature Version must be 3, and should be along with the Expires parameter -- ignoring request.");
                 return false;

server/src/main/java/com/cloud/api/ApiServlet.java

@@ -323,7 +323,7 @@ void processRequestInContext(final HttpServletRequest req, final HttpServletResp
                 }
             }
 
-            if (apiServer.isEnforcePostRequestsAndTimestamps() && !isStateChangingCommandUsingPOST(command, req.getMethod(), params)) {
+            if (apiServer.isPostRequestsAndTimestampsEnforced() && !isStateChangingCommandUsingPOST(command, req.getMethod(), params)) {
                 String errorText = String.format("State changing command %s needs to be sent using POST request", command);
                 if (command.equalsIgnoreCase("updateConfiguration") && params.containsKey("name")) {
                     errorText = String.format("Changes for configuration %s needs to be sent using POST request", params.get("name")[0]);