Skip to content

Commit cfe9746

Browse files
committed
fix UT and schema
1 parent eb4b9e3 commit cfe9746

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

engine/schema/src/main/resources/META-INF/db/schema-41930to41940.sql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
--;
2121

2222
-- Add vm_id column to usage_event table for volume usage events
23-
ALTER TABLE `cloud`.`usage_event` ADD COLUMN `vm_id` bigint unsigned NULL COMMENT 'VM ID associated with volume usage events';
24-
ALTER TABLE `cloud_usage`.`usage_event` ADD COLUMN `vm_id` bigint unsigned NULL COMMENT 'VM ID associated with volume usage events';
23+
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.usage_event','vm_id', 'bigint UNSIGNED NULL COMMENT "VM ID associated with volume usage events"');
24+
CALL `cloud_usage`.`IDEMPOTENT_ADD_COLUMN`('cloud_usage.usage_event','vm_id', 'bigint UNSIGNED NULL COMMENT "VM ID associated with volume usage events"');
2525

2626
-- Add vm_id column to cloud_usage.usage_volume table
27-
ALTER TABLE `cloud_usage`.`usage_volume` ADD COLUMN `vm_id` bigint unsigned NULL COMMENT 'VM ID associated with the volume usage';
27+
CALL `cloud_usage`.`IDEMPOTENT_ADD_COLUMN`('cloud_usage.usage_volume','vm_id', 'bigint UNSIGNED NULL COMMENT "VM ID associated with the volume usage"');

server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import com.cloud.deploy.DeployDestination;
2727
import com.cloud.deploy.DeploymentPlanner;
2828
import com.cloud.deploy.DeploymentPlanningManager;
29+
import com.cloud.event.UsageEventUtils;
2930
import com.cloud.exception.InsufficientAddressCapacityException;
3031
import com.cloud.exception.InsufficientCapacityException;
3132
import com.cloud.exception.InsufficientServerCapacityException;
@@ -100,6 +101,7 @@
100101
import org.junit.runner.RunWith;
101102
import org.mockito.InjectMocks;
102103
import org.mockito.Mock;
104+
import org.mockito.MockedStatic;
103105
import org.mockito.Mockito;
104106
import org.mockito.Spy;
105107
import org.mockito.junit.MockitoJUnitRunner;
@@ -273,6 +275,7 @@ public class UserVmManagerImplTest {
273275

274276
private DiskOfferingVO smallerDisdkOffering = prepareDiskOffering(5l * GiB_TO_BYTES, 1l, 1L, 2L);
275277
private DiskOfferingVO largerDisdkOffering = prepareDiskOffering(10l * GiB_TO_BYTES, 2l, 10L, 20L);
278+
private MockedStatic<UsageEventUtils> usageEventUtilsMocked;
276279

277280
@Before
278281
public void beforeTest() {
@@ -291,11 +294,13 @@ public void beforeTest() {
291294
lenient().doNothing().when(resourceLimitMgr).decrementResourceCount(anyLong(), any(Resource.ResourceType.class), anyLong());
292295

293296
Mockito.when(virtualMachineProfile.getId()).thenReturn(vmId);
297+
usageEventUtilsMocked = Mockito.mockStatic(UsageEventUtils.class);
294298
}
295299

296300
@After
297301
public void afterTest() {
298302
CallContext.unregister();
303+
usageEventUtilsMocked.close();
299304
}
300305

301306
@Test

0 commit comments

Comments
 (0)