implement_custom_stabby_friendly_ffi

Author: coderfender

Cargo.lock

@@ -22,7 +22,6 @@ edition = { workspace = true }
 publish = false
 
 [dependencies]
-abi_stable = "0.11.3"
 arrow = { workspace = true }
 datafusion = { workspace = true }
 datafusion-ffi = { workspace = true }

datafusion-examples/examples/ffi/ffi_example_table_provider/Cargo.toml

@@ -17,13 +17,12 @@
 
 use std::sync::Arc;
 
-use abi_stable::{export_root_module, prefix_type::PrefixTypeTrait};
 use arrow::array::RecordBatch;
 use arrow::datatypes::{DataType, Field, Schema};
 use datafusion::{common::record_batch, datasource::MemTable};
 use datafusion_ffi::proto::logical_extension_codec::FFI_LogicalExtensionCodec;
 use datafusion_ffi::table_provider::FFI_TableProvider;
-use ffi_module_interface::{TableProviderModule, TableProviderModuleRef};
+use ffi_module_interface::TableProviderModule;
 
 fn create_record_batch(start_value: i32, num_values: usize) -> RecordBatch {
     let end_value = start_value + num_values as i32;
@@ -56,11 +55,10 @@ extern "C" fn construct_simple_table_provider(
     FFI_TableProvider::new_with_ffi_codec(Arc::new(table_provider), true, None, codec)
 }
 
-#[export_root_module]
+#[unsafe(no_mangle)]
 /// This defines the entry point for using the module.
-pub fn get_simple_memory_table() -> TableProviderModuleRef {
+pub extern "C" fn ffi_example_get_module() -> TableProviderModule {
     TableProviderModule {
         create_table: construct_simple_table_provider,
     }
-    .leak_into_prefix()
 }

datafusion-examples/examples/ffi/ffi_example_table_provider/src/lib.rs

@@ -25,5 +25,4 @@ publish = false
 workspace = true
 
 [dependencies]
-abi_stable = "0.11.3"
 datafusion-ffi = { workspace = true }

datafusion-examples/examples/ffi/ffi_module_interface/Cargo.toml

@@ -15,36 +15,17 @@
 // specific language governing permissions and limitations
 // under the License.
 
-use abi_stable::{
-    StableAbi, declare_root_module_statics,
-    library::{LibraryError, RootModule},
-    package_version_strings,
-    sabi_types::VersionStrings,
-};
 use datafusion_ffi::proto::logical_extension_codec::FFI_LogicalExtensionCodec;
 use datafusion_ffi::table_provider::FFI_TableProvider;
 
-#[repr(C)]
-#[derive(StableAbi)]
-#[sabi(kind(Prefix(prefix_ref = TableProviderModuleRef)))]
 /// This struct defines the module interfaces. It is to be shared by
 /// both the module loading program and library that implements the
 /// module. It is possible to move this definition into the loading
 /// program and reference it in the modules, but this example shows
 /// how a user may wish to separate these concerns.
+#[repr(C)]
 pub struct TableProviderModule {
     /// Constructs the table provider
     pub create_table:
         extern "C" fn(codec: FFI_LogicalExtensionCodec) -> FFI_TableProvider,
 }
-
-impl RootModule for TableProviderModuleRef {
-    declare_root_module_statics! {TableProviderModuleRef}
-    const BASE_NAME: &'static str = "ffi_example_table_provider";
-    const NAME: &'static str = "ffi_example_table_provider";
-    const VERSION_STRINGS: VersionStrings = package_version_strings!();
-
-    fn initialization(self) -> Result<Self, LibraryError> {
-        Ok(self)
-    }
-}

datafusion-examples/examples/ffi/ffi_module_interface/src/lib.rs

@@ -25,8 +25,8 @@ publish = false
 workspace = true
 
 [dependencies]
-abi_stable = "0.11.3"
 datafusion = { workspace = true }
 datafusion-ffi = { workspace = true }
 ffi_module_interface = { path = "../ffi_module_interface" }
+libloading = "0.8"
 tokio = { workspace = true, features = ["rt-multi-thread", "parking_lot"] }