Address the review comments

Author: bchapuis

baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetWriteSupport.java

@@ -32,9 +32,10 @@
  */
 public class GeoParquetWriteSupport extends WriteSupport<GeoParquetGroup> {
 
-  private RecordConsumer recordConsumer;
+  private Configuration configuration;
   private final MessageType schema;
   private final GeoParquetMetadata metadata;
+  private RecordConsumer recordConsumer;
   private final ObjectMapper objectMapper = new ObjectMapper();
 
   /**

baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetWriter.java

@@ -48,26 +48,48 @@ private Builder(Path file) {
       super(file);
     }
 
+    /**
+     * Replace the message type with the specified one.
+     *
+     * @param type the message type
+     * @return the builder
+     */
     public GeoParquetWriter.Builder withType(MessageType type) {
       this.type = type;
       return this;
     }
 
+    /**
+     * Replace the metadata with the specified one.
+     *
+     * @param metadata the metadata
+     * @return the builder
+     */
     public GeoParquetWriter.Builder withGeoParquetMetadata(GeoParquetMetadata metadata) {
       this.metadata = metadata;
       return this;
     }
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     protected WriteSupport<GeoParquetGroup> getWriteSupport(Configuration conf) {
+      // We don't need access to the hadoop configuration for now
       return getWriteSupport((ParquetConfiguration) null);
     }
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     protected WriteSupport<GeoParquetGroup> getWriteSupport(ParquetConfiguration conf) {
       return new GeoParquetWriteSupport(type, metadata);
     }
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     protected GeoParquetWriter.Builder self() {
       return this;

baremaps-geoparquet/src/test/java/org/apache/baremaps/geoparquet/GeoParquetWriterTest.java

@@ -22,6 +22,7 @@
 
 import java.io.IOException;
 import java.util.HashMap;
+import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 import org.apache.baremaps.geoparquet.GeoParquetMetadata.Column;
@@ -121,30 +122,33 @@ void testWriteAndReadGeoParquet() throws IOException {
 
   @Test
   @Tag("integration")
-  void copy() throws IOException {
+  void copyGeoParquetData() throws IOException {
     Path geoParquet = new Path(TestFiles.GEOPARQUET.toUri());
 
     Configuration conf = new Configuration();
     Path outputPath = new Path("target/test-output/geoparquet-copy.parquet");
 
     try {
+      // Write the GeoParquet file
       GeoParquetReader reader = new GeoParquetReader(geoParquet, null, conf);
       GeoParquetWriter.Builder builder = GeoParquetWriter.builder(outputPath);
       ParquetWriter<GeoParquetGroup> writer = builder.withType(reader.getParquetSchema())
           .withGeoParquetMetadata(reader.getGeoParquetMetadata()).build();
-      reader.read().forEach(group -> {
-        System.out.println(group);
-        try {
-          writer.write(group);
-        } catch (IOException e) {
-          e.printStackTrace();
-        }
-      });
-    } catch (IOException e) {
-      e.printStackTrace();
+      Iterator<GeoParquetGroup> iterator = reader.read().iterator();
+      while (iterator.hasNext()) {
+        writer.write(iterator.next());
+      }
+      writer.close();
+
+      // Read the copied file
+      GeoParquetReader copiedReader = new GeoParquetReader(outputPath, null, conf);
+      assertEquals(5, copiedReader.read().count());
     } finally {
       outputPath.getFileSystem(conf).delete(outputPath, false);
     }
+
+
+
   }
 
 }