Fix automatic module names and missing methanol (#1651)

They were generated as illegal. See:
https://github.com/sormuras/modules/blob/main/doc/suspicious/illegal-automatic-module-names.txt

This goes along with coordinate change of `-jdk8` and `-jdk11` constituents, but hopefully nothing addresses those (at least in Maven), as everything should use the `-jdk` MR-JAR instead (created out of those two constituents). Also, by reordering m-dependency-p invocation, it is not overwriting now the bnd generated manifest, and it also fixes its module name as well.

Another issue was Methanol, as MR-JAR did not enlist it as dependency, leading to defunct MR-JAR of jdk transport.

Author: cstamas

maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-8/src/main/java/org/eclipse/aether/transport/jdk/JdkRFC9457Reporter.java

@@ -43,17 +43,21 @@
     <!-- These dependencies are actually included in this multi-release JAR -->
     <dependency>
       <groupId>org.apache.maven.resolver</groupId>
-      <artifactId>maven-resolver-transport-jdk-8</artifactId>
+      <artifactId>maven-resolver-transport-jdk8</artifactId>
       <version>${project.version}</version>
       <optional>true</optional>
     </dependency>
     <dependency>
       <groupId>org.apache.maven.resolver</groupId>
-      <artifactId>maven-resolver-transport-jdk-11</artifactId>
+      <artifactId>maven-resolver-transport-jdk11</artifactId>
       <version>${project.version}</version>
       <optional>true</optional>
     </dependency>
 
+    <dependency>
+      <groupId>com.github.mizosoft.methanol</groupId>
+      <artifactId>methanol</artifactId>
+    </dependency>
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-api</artifactId>
@@ -104,9 +108,9 @@
             <goals>
               <goal>unpack-dependencies</goal>
             </goals>
-            <phase>prepare-package</phase>
+            <phase>generate-resources</phase>
             <configuration>
-              <includeArtifactIds>maven-resolver-transport-jdk-8</includeArtifactIds>
+              <includeArtifactIds>maven-resolver-transport-jdk8</includeArtifactIds>
               <excludeClassifiers>sources</excludeClassifiers>
               <outputDirectory>${project.build.outputDirectory}</outputDirectory>
               <excludes>META-INF/maven/**</excludes>
@@ -117,9 +121,9 @@
             <goals>
               <goal>unpack-dependencies</goal>
             </goals>
-            <phase>prepare-package</phase>
+            <phase>generate-resources</phase>
             <configuration>
-              <includeArtifactIds>maven-resolver-transport-jdk-11</includeArtifactIds>
+              <includeArtifactIds>maven-resolver-transport-jdk11</includeArtifactIds>
               <excludeClassifiers>sources</excludeClassifiers>
               <outputDirectory>${project.build.outputDirectory}/META-INF/versions/11</outputDirectory>
               <includes>**/*.class</includes>

maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk/pom.xml

@@ -26,7 +26,7 @@
     <version>2.0.14-SNAPSHOT</version>
   </parent>
 
-  <artifactId>maven-resolver-transport-jdk-11</artifactId>
+  <artifactId>maven-resolver-transport-jdk11</artifactId>
   <packaging>jar</packaging>
 
   <name>Maven Artifact Resolver Transport JDK 11</name>
@@ -56,7 +56,6 @@
     <dependency>
       <groupId>com.github.mizosoft.methanol</groupId>
       <artifactId>methanol</artifactId>
-      <version>1.8.4</version>
     </dependency>
     <dependency>
       <groupId>javax.inject</groupId>

maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/pom.xml renamed to maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk11/pom.xml

@@ -26,7 +26,7 @@
     <version>2.0.14-SNAPSHOT</version>
   </parent>
 
-  <artifactId>maven-resolver-transport-jdk-8</artifactId>
+  <artifactId>maven-resolver-transport-jdk8</artifactId>
   <packaging>jar</packaging>
 
   <name>Maven Artifact Resolver Transport JDK 8</name>