Work out the TODO

Author: cstamas

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/filter/PrefixesRemoteRepositoryFilterSource.java

@@ -150,6 +150,24 @@ public final class PrefixesRemoteRepositoryFilterSource extends RemoteRepository
 
     public static final boolean DEFAULT_USE_MIRRORED_REPOSITORIES = false;
 
+    /**
+     * Configuration to allow Prefixes filter to auto-discover prefixes from repository managers as well. For this to
+     * work <em>Maven should be aware</em> that given remote repository is backed by repository manager.
+     * Given multiple MRM implementations messes up prefixes file, is better to just skip these. In other case, one may use
+     * {@link #CONFIG_PROP_ENABLED} with repository ID suffix.
+     * <em>Note: as of today, nothing sets this on remote repositories, but is added for future.</em>
+     *
+     * @since 2.0.14
+     * @configurationSource {@link RepositorySystemSession#getConfigProperties()}
+     * @configurationType {@link java.lang.Boolean}
+     * @configurationRepoIdSuffix Yes
+     * @configurationDefaultValue {@link #DEFAULT_USE_REPOSITORY_MANAGERS}
+     */
+    public static final String CONFIG_PROP_USE_REPOSITORY_MANAGERS =
+            RemoteRepositoryFilterSourceSupport.CONFIG_PROPS_PREFIX + NAME + ".useRepositoryManagers";
+
+    public static final boolean DEFAULT_USE_REPOSITORY_MANAGERS = false;
+
     /**
      * The basedir where to store filter files. If path is relative, it is resolved from local repository root.
      *
@@ -301,10 +319,14 @@ private Path resolvePrefixesFromLocalConfiguration(
 
     private boolean supportedResolvePrefixesForRemoteRepository(
             RepositorySystemSession session, RemoteRepository remoteRepository) {
-        // TODO: RemoteRepository.isRepositoryManager() is still unused in Maven; once used, factor it in
-        return remoteRepository.getMirroredRepositories().isEmpty()
-                || ConfigUtils.getBoolean(
-                        session, DEFAULT_USE_MIRRORED_REPOSITORIES, CONFIG_PROP_USE_MIRRORED_REPOSITORIES);
+        if (remoteRepository.isRepositoryManager()) {
+            return ConfigUtils.getBoolean(
+                    session, DEFAULT_USE_REPOSITORY_MANAGERS, CONFIG_PROP_USE_REPOSITORY_MANAGERS);
+        } else {
+            return remoteRepository.getMirroredRepositories().isEmpty()
+                    || ConfigUtils.getBoolean(
+                            session, DEFAULT_USE_MIRRORED_REPOSITORIES, CONFIG_PROP_USE_MIRRORED_REPOSITORIES);
+        }
     }
 
     private Path resolvePrefixesFromRemoteRepository(

src/site/markdown/configuration.md

@@ -106,6 +106,7 @@ To modify this file, edit the template and regenerate.
 | `"aether.remoteRepositoryFilter.prefixes.basedir"` | `String` | The basedir where to store filter files. If path is relative, it is resolved from local repository root. |  `".remoteRepositoryFilters"`  | 1.9.0 |  No  | Session Configuration |
 | `"aether.remoteRepositoryFilter.prefixes.skipped"` | `Boolean` | Configuration to skip the Prefixes filter for given request. This configuration is evaluated and if <code>true</code> the prefixes remote filter will not kick in. Main use case is by filter itself, to prevent recursion during discovery of remote prefixes file, but this also allows other components to control prefix filter discovery, while leaving configuration like <code>#CONFIG_PROP_ENABLED</code> still show the "real state". |  `false`  | 2.0.14 |  Yes  | Session Configuration |
 | `"aether.remoteRepositoryFilter.prefixes.useMirroredRepositories"` | `Boolean` | Configuration to allow Prefixes filter to auto-discover prefixes from mirrored repositories as well. For this to work <em>Maven should be aware</em> that given remote repository is mirror and is usually backed by MRM. Given multiple MRM implementations messes up prefixes file, is better to just skip these. In other case, one may use <code>#CONFIG_PROP_ENABLED</code> with repository ID suffix. |  `false`  | 2.0.14 |  Yes  | Session Configuration |
+| `"aether.remoteRepositoryFilter.prefixes.useRepositoryManagers"` | `Boolean` | Configuration to allow Prefixes filter to auto-discover prefixes from repository managers as well. For this to work <em>Maven should be aware</em> that given remote repository is backed by repository manager. Given multiple MRM implementations messes up prefixes file, is better to just skip these. In other case, one may use <code>#CONFIG_PROP_ENABLED</code> with repository ID suffix. <em>Note: as of today, nothing sets this on remote repositories, but is added for future.</em> |  `false`  | 2.0.14 |  Yes  | Session Configuration |
 | `"aether.snapshotFilter"` | `Boolean` | The key in the repository session's <code>RepositorySystemSession#getConfigProperties() configurationproperties</code> used to store a <code>Boolean</code> flag whether this filter should be forced to ban snapshots. By default, snapshots are only filtered if the root artifact is not a snapshot. |  `false`  |  |  No  | Session Configuration |
 | `"aether.syncContext.named.basedir.locksDir"` | `String` | The location of the directory toi use for locks. If relative path, it is resolved from the local repository root. |  `".locks"`  | 1.9.0 |  No  | Session Configuration |
 | `"aether.syncContext.named.discriminating.discriminator"` | `String` | Configuration property to pass in discriminator, if needed. If not present, it is auto-calculated. |  -  | 1.7.0 |  No  | Session Configuration |