Skip to content

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Jul 9, 2025

No description provided.

@elharo elharo marked this pull request as ready for review July 9, 2025 13:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an unused Maven dependency to streamline the project’s dependency list.

  • Removed the maven-resolver-util dependency from the supplier module.

@elharo elharo added dependencies Pull requests that update a dependency file skip-changelog Skip this PR from automatically changelog generation labels Jul 27, 2025
@elharo elharo merged commit bf3f235 into maven-resolver-1.9.x Jul 27, 2025
28 checks passed
@elharo elharo deleted the depsutil branch July 27, 2025 10:57
@cstamas
Copy link
Member

cstamas commented Nov 14, 2025

This is wrong PR ill advised by a tool that lacks context, and people blindly following it. The purpose of supplier is explained here:
https://maven.apache.org/resolver-archives/resolver-1.9.24/third-party-integrations.html

This needs to be undone, by removing util you made it "third level" transitive dep for those who use supplier. The resolver artifact must be aligned on classpath, and this change endangers that intent.

@elharo
Copy link
Contributor Author

elharo commented Nov 14, 2025

This file doesn't seem to exist any more.

@cstamas
Copy link
Member

cstamas commented Nov 14, 2025

It exists, trust me, on the branch this PR targeted.

@elharo
Copy link
Contributor Author

elharo commented Nov 14, 2025

OK, I'm looking at it but I'm not sure including the dependency is the correct or reliable way to ensure version alignment. It seems likely to depend on which dependencies are declared where in which order. Someone could still pull maven-resolver-util into their project with a different version before they pull in maven-resolver-supplier. Is there some reason that can't happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file skip-changelog Skip this PR from automatically changelog generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants