Skip to content

Commit 9d3b264

Browse files
authored
Merge branch 'master' into feat_serviceManager
2 parents b823d33 + 6632d5e commit 9d3b264

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

shenyu-integrated-test/shenyu-integrated-test-motan/src/test/java/org/apache/shenyu/integrated/test/motan/MotanPluginTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public class MotanPluginTest extends AbstractPluginDataInit {
3636

3737
@BeforeAll
3838
public static void setup() throws IOException {
39-
String pluginResult = initPlugin(PluginEnum.MOTAN.getName(), "{\"registerAddress\":shenyu-zk:2181\"\",\"registerProtocol\":\"zk\"}");
39+
String pluginResult = initPlugin(PluginEnum.MOTAN.getName(), "{\"registerAddress\":\"shenyu-zk:2181\",\"registerProtocol\":\"zk\"}");
4040
assertThat(pluginResult, is("success"));
4141
}
4242

shenyu-plugin/shenyu-plugin-base/src/main/java/org/apache/shenyu/plugin/base/cache/CommonPluginDataSubscriber.java

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import org.apache.shenyu.common.enums.PluginHandlerEventEnum;
2828
import org.apache.shenyu.common.enums.TrieCacheTypeEnum;
2929
import org.apache.shenyu.common.enums.TrieEventEnum;
30+
import org.apache.shenyu.common.utils.JsonUtils;
3031
import org.apache.shenyu.common.utils.MapUtils;
3132
import org.apache.shenyu.plugin.api.utils.SpringBeanUtils;
3233
import org.apache.shenyu.plugin.base.event.TrieEvent;
@@ -195,12 +196,16 @@ public void refreshRuleDataSelf(final List<RuleData> ruleDataList) {
195196
}
196197

197198
private <T> void subscribeDataHandler(final T classData, final DataEventTypeEnum dataType) {
198-
if (dataType == DataEventTypeEnum.UPDATE) {
199-
Optional.ofNullable(classData)
200-
.ifPresent(data -> updateCacheData(classData));
201-
} else if (dataType == DataEventTypeEnum.DELETE) {
202-
Optional.ofNullable(classData)
203-
.ifPresent(data -> removeCacheData(classData));
199+
try {
200+
if (dataType == DataEventTypeEnum.UPDATE) {
201+
Optional.ofNullable(classData)
202+
.ifPresent(data -> updateCacheData(classData));
203+
} else if (dataType == DataEventTypeEnum.DELETE) {
204+
Optional.ofNullable(classData)
205+
.ifPresent(data -> removeCacheData(classData));
206+
}
207+
} catch (Exception e) {
208+
LOG.error("subscribe data handler error, classData: {}, dataType: {}", JsonUtils.toJson(classData), dataType, e);
204209
}
205210
}
206211

0 commit comments

Comments
 (0)