TextAreaControl component's modal mode is limited to 11 rows and does not fill the entire height of the modal window

[mastavichus-vp]

Hello friends!

Since Superset version 4.0.0, I've noticed some carelessness or oversight in the component TextAreaControl:
superset-frontend/src/explore/components/controls/TextAreaControl.jsx

The issue manifests as follows: in the modal window, the edit field is limited to 11 rows in height, even though the code explicitly sets minLines = 40 for the modal.

To correct this, the properties need to be passed in the correct order so that the minLines and maxLines values in modal mode receive the required priority.

class TextAreaControl extends Component {
  const minLines = inModal ? 40 : this.props.minLines || 12;
  ...
  <TextAreaEditor
    ...
    // This will be ahead (first)
    {...this.props}
    ...
    // Now need to pass special values for the modal mode
    minLines={minLines}
    maxLines={inModal ? 1000 : this.props.maxLines}
    ...
  />
}

I hope this doesn't go unnoticed. Thank you!

[dosubot[bot]]

Hi @mastavichus-vp! I'm Dosu and I’m helping the superset team.

You are correct—the current implementation of TextAreaControl spreads {...this.props} after explicitly setting minLines and maxLines, which means any minLines or maxLines passed in via props will override the intended modal values. This is why the modal is limited to 11 rows, even though minLines is set to 40 for modal mode in the code. Changing the order so that {...this.props} comes before the explicit minLines and maxLines ensures the modal values take priority and fixes the issue where the modal does not fill the available height as expected. You can see this in the current code structure and prop order in the component's implementation citation. No existing issues or PRs directly address this, so your proposed fix is spot on.

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}