graphql.md: add "MediaObject Normalization" chapter #2109
Conversation
timble-one
force-pushed
the
graphql-media-object-normalization
branch
from
99ecafc to
0c170e2
Compare
vinceAmstoutz
left a comment
vinceAmstoutz
left a comment
There was a problem hiding this comment.
@71m024 Tanks for your contribution!
Can you please add more explanation on the “Why”?
Also, can you add an injection example for Laravel? As you can see here with an example of injection, we now document both Symfony and Laravel (since 4.0).
|
@timble-one Do you plan to keep going? |
timble-one
force-pushed
the
graphql-media-object-normalization
branch
from
0c170e2 to
cc72224
Compare
|
@vinceAmstoutz I made it i little bit clearer, that the injected normalizer must be replaced with the one from the graphql namespace. Otherwise it won't work if you just do it like it is done here: https://api-platform.com/docs/symfony/file-upload/ I have never used Laravel before. If this must be ported to the Laravel Documentation it should be done be someone who has experience. |
timble-one
force-pushed
the
graphql-media-object-normalization
branch
from
cc72224 to
2a9a455
Compare
|
I think the linting Problem is not caused by this PR. |
@timble-one Yes you're right, could you please rebase it from the |
timble-one
force-pushed
the
graphql-media-object-normalization
branch
from
2a9a455 to
196715a
Compare
graphql-normalizer needs to be injected
timble-one
force-pushed
the
graphql-media-object-normalization
branch
from
196715a to
b0c9e2b
Compare
There was a problem hiding this comment.
Should be great for me after theses changes @timble-one
optimization from @vinceAmstoutz Co-authored-by: Vincent Amstoutz <[email protected]>
optimization from @vinceAmstoutz Co-authored-by: Vincent Amstoutz <[email protected]>
vinceAmstoutz
requested review from
alanpoulain,
soyuka and
vincentchalamon
|
Thanks @timble-one! |
* graphql.md: add "MediaObject Normalization" chapter graphql-normalizer needs to be injected * graphql.md: add "MediaObject Normalization" chapter optimization from @vinceAmstoutz Co-authored-by: Vincent Amstoutz <[email protected]> * graphql.md: add "MediaObject Normalization" chapter optimization from @vinceAmstoutz Co-authored-by: Vincent Amstoutz <[email protected]> --------- Co-authored-by: Vincent Amstoutz <[email protected]>
3 participants
graphql-normalizer needs to be injected