Skip to content

WebApp.addHtmlAttributeHook hooks are not cleared on HMR updates #92

@marsimeau

Description

@marsimeau

When calling a WebApp.addHtmlAttributeHook, previous hooks are not cleared upon HMR updates.

It's worth noting that this doesn't seem to any negative impact on my app.

Test done locally:

// ...

const randomNumber = Math.random()

WebApp.addHtmlAttributeHook(req => {
  console.log(randomNumber)

  return null
})

Here is what the console returns after 2 updates on each request:

0.6168036561182655
0.06950770055811595
0.5245338011658636

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions