Update test for .Failed handling of ancestors #14938
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor test for DependencyTypeItems ancestor handling. Signed-off-by: Jeroen Peelaerts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor test for DependencyTypeItems ancestor handling. Add case to detect a potential regression
Fixes #TODO
Motivation
We faced a regression after upgrading to argo 3.7.2 with the Task depends logic. It seems that for some reason the evaluation of
task1.Failedstopped working for a task that has a dependency on a fan out step.Modifications
Add a testcase to verify the
.Failedflag is working when used in the task.dependsVerification
I'm testing them through this PR
Documentation