removes black in favor of ruff (#696)

aloctavodia · web-flow · commit 64994d7d03ae · 2025-10-22T10:26:00.000+03:00
* remove black

* remove black

* update test

* change test value

* change test value

* update env
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -15,7 +15,7 @@ Thank you so much for your PR! To help us review your contribution, please consi
 ## Checklist
 <!-- Feel free to remove check-list items that aren't relevant to your change -->
 
-- [ ] Code style is correct (follows ruff and black guidelines)
+- [ ] Code style is correct (follows ruff guidelines)
 - [ ] Includes new or updated tests to cover the new feature
 - [ ] New features are properly documented (with an example if appropriate)
 - [ ] Includes a sample plot to visually illustrate the changes (only for plot-related functions)
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -43,8 +43,6 @@ jobs:
       - name: Run linters
         shell: bash -l {0}
         run: |
-          python -m black preliz --check
-          echo "Success!"
           echo "Checking code style with ruff..."
           ruff check preliz/
       - name: Run tests
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -1,18 +1,14 @@
 fail_fast: true
 
 repos:
-  - repo: https://github.com/ambv/black
-    rev: 22.3.0
-    hooks:
-      - id: black
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.6.8
+    rev: v0.14.1
     hooks:
       - id: ruff
         args: [ --fix, --exit-non-zero-on-fix ]
       - id: ruff-format
         types_or: [ python, pyi ]
   - repo: https://github.com/MarcoGorelli/madforhooks
-    rev: 0.3.0
+    rev: 0.4.1
     hooks:
       - id: no-print-statements
diff --git a/README.md b/README.md
@@ -6,7 +6,7 @@ Exploring and eliciting probability distributions
 [![PyPi version](https://badge.fury.io/py/preliz.svg)](https://badge.fury.io/py/preliz)
 [![Build Status](https://github.com/arviz-devs/preliz/actions/workflows/test.yml/badge.svg)](https://github.com/arviz-devs/preliz/actions/workflows/test.yml)
 [![codecov](https://codecov.io/gh/arviz-devs/preliz/branch/master/graph/badge.svg?token=SLJIK2O4C5 )](https://codecov.io/gh/arviz-devs/preliz/)
-[![Code style: black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/ambv/black)
+[![Ruff](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/astral-sh/ruff/main/assets/badge/v2.json)](https://github.com/astral-sh/ruff)
 [![DOI](https://joss.theoj.org/papers/10.21105/joss.05499/status.svg)](https://doi.org/10.21105/joss.05499)
 
 ## Overview
diff --git a/docs/conf.py b/docs/conf.py
@@ -52,7 +52,7 @@
     "sphinx_tabs.tabs",
     "sphinx_design",
     "jupyter_sphinx",
-    "sphinxcontrib.bibtex"
+    "sphinxcontrib.bibtex",
 ]
 
 # -- Extension configuration -------------------------------------------------
@@ -146,7 +146,7 @@
 
 # -- For Bibtex files ---------------------------------------------
 
-bibtex_bibfiles = ['../preliz/internal/reference.bib']
+bibtex_bibfiles = ["../preliz/internal/reference.bib"]
 
 # -- Options for LaTeX output ------------------------------------------------
 
diff --git a/docs/get_cover_gallery.py b/docs/get_cover_gallery.py
@@ -19,7 +19,7 @@
 for name, params in init_vals.items():
     try:
         dist_kind = getattr(distributions, name)().kind
-    except:
+    except TypeError:
         dist_kind = "modifier"
     color = category_colors.get(dist_kind, "C3")
     _, ax = plt.subplots(figsize=(3.5, 2.3))
diff --git a/docs/index.rst b/docs/index.rst
@@ -4,7 +4,7 @@ Exploring and eliciting probability distributions
 |PyPI version|
 |Tests|
 |Coverage|
-|Black|
+|Ruff|
 |DOI|
 
 .. |PyPI version| image:: https://badge.fury.io/py/preliz.svg
@@ -16,8 +16,8 @@ Exploring and eliciting probability distributions
 .. |Coverage| image:: https://codecov.io/gh/arviz-devs/preliz/branch/main/graph/badge.svg?token=SLJIK2O4C5 
     :target: https://codecov.io/gh/arviz-devs/preliz
 
-.. |Black| image:: https://img.shields.io/badge/code%20style-black-000000.svg
-    :target: https://github.com/ambv/black
+.. |Ruff| image:: https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/astral-sh/ruff/main/assets/badge/v2.json
+    :target: https://github.com/astral-sh/ruff
 
 .. |DOI| image:: https://joss.theoj.org/papers/10.21105/joss.05499/status.svg
    :target: https://doi.org/10.21105/joss.05499
diff --git a/environment-dev.yml b/environment-dev.yml
@@ -5,16 +5,15 @@ channels:
 dependencies:
   - python >= 3.11
   - pip
-  - matplotlib>=3.8
-  - numba>=0.60
+  - matplotlib>=3.9
+  - numba>=0.62
   - numpy>=2.0
   - scipy>=1.12
   - nbclient>=0.2
   - ipywidgets
   - ipympl
   - jupyterlab
   - notebook
-  - black==22.3.0
   - click
   - pytest-cov>=2.6.1
   - pytest>=4.4.0
diff --git a/preliz/distributions/asymmetric_laplace.py b/preliz/distributions/asymmetric_laplace.py
@@ -129,9 +129,7 @@ def entropy(self):
 
     def median(self):
         if self.kappa > 1:
-            return self.mu + self.kappa * self.b * np.log(
-                (1 + self.kappa**2) / (2 * self.kappa**2)
-            )
+            return self.mu + self.kappa * self.b * np.log((1 + self.kappa**2) / (2 * self.kappa**2))
         return self.mu - np.log((1 + self.kappa**2) / 2) / (self.kappa / self.b)
 
     def mean(self):
diff --git a/preliz/distributions/distributions.py b/preliz/distributions/distributions.py
@@ -267,8 +267,7 @@ def moments(self, types="mvsk"):
         for m_t in types:
             if m_t not in "mdvsk":
                 raise ValueError(
-                    "The input string should only contain the letters "
-                    "'m', 'd', 'v', 's', or 'k'."
+                    "The input string should only contain the letters 'm', 'd', 'v', 's', or 'k'."
                 )
             if m_t == "m":
                 moments.append(self.mean())
diff --git a/preliz/distributions/truncatednormal.py b/preliz/distributions/truncatednormal.py
@@ -402,7 +402,5 @@ def nb_rvs(random_samples, mu, sigma, lower, upper):
     alpha = (lower - mu) / sigma
     beta = (upper - mu) / sigma
     z_val = 0.5 * (1 + erf(beta / 2**0.5)) - 0.5 * (1 + erf(alpha / 2**0.5))
-    inv_phi = 2**0.5 * erfinv(
-        2 * (0.5 * (1 + erf(alpha / 2**0.5)) + random_samples * z_val) - 1
-    )
+    inv_phi = 2**0.5 * erfinv(2 * (0.5 * (1 + erf(alpha / 2**0.5)) + random_samples * z_val) - 1)
     return inv_phi * sigma + mu
diff --git a/preliz/internal/rcparams.py b/preliz/internal/rcparams.py
@@ -42,7 +42,7 @@ def validate_choice(value):
             value = {"true": True, "false": False}.get(value, value)
             return value
         raise ValueError(
-            f'{value} is not one of {accepted_values}{" nor None" if allow_none else ""}'
+            f"{value} is not one of {accepted_values}{' nor None' if allow_none else ''}"
         )
 
     return validate_choice
diff --git a/preliz/ppls/bambi_io.py b/preliz/ppls/bambi_io.py
@@ -36,9 +36,9 @@ def write_bambi_string(new_priors, var_info):
                 dist_name, dist_params = repr(cp_dist).split("(")
                 size = var_info[nkey][1]
                 if size > 1:
-                    variables[
-                        i
-                    ] = f'"{nkey}" : bmb.Prior("{dist_name}", {dist_params}, shape={size}),\n'
+                    variables[i] = (
+                        f'"{nkey}" : bmb.Prior("{dist_name}", {dist_params}, shape={size}),\n'
+                    )
                 else:
                     variables[i] = f'"{nkey}" : bmb.Prior("{dist_name}", {dist_params}),\n'
         else:
@@ -83,7 +83,7 @@ def from_bambi(fmodel, draws):
             f"{indentation}{variable_name}.build()\n"
             f"{indentation}variables = [{variable_name}.backend.model.named_vars[v] "
             f"for v in {return_variables}]\n"
-            f'{indentation}{", ".join(return_variables)} = pm.draw(variables, draws={draws})',
+            f"{indentation}{', '.join(return_variables)} = pm.draw(variables, draws={draws})",
         )
 
         # Find the priors we want to change
diff --git a/preliz/unidimensional/maxent.py b/preliz/unidimensional/maxent.py
@@ -147,7 +147,7 @@ def maxent(
 
     if r_error > 0.01:
         warnings.warn(
-            f"\nThe requested mass is {mass:.3g},\n" f"but the computed one is {computed_mass:.3g}",
+            f"\nThe requested mass is {mass:.3g},\nbut the computed one is {computed_mass:.3g}",
             stacklevel=2,
         )
 
diff --git a/pyproject.toml b/pyproject.toml
@@ -26,8 +26,8 @@ dynamic = ["version"]
 description = "Exploring and eliciting probability distributions."
 dependencies = [
   "arviz_stats>=0.6.0",  
-  "matplotlib>=3.8",
-  "numba>=0.59",
+  "matplotlib>=3.9",
+  "numba>=0.62",
   "numpy>=2.0",
   "scipy>=1.12"
 ]
@@ -50,8 +50,6 @@ full = [
 lab = ["jupyterlab"]
 notebook = ["notebook"]
 
-[tool.black]
-line-length = 100
 
 [tool.isort]
 profile = "black"
diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -1,4 +1,3 @@
-black==22.3.0
 click
 pytest-cov>=2.6.1
 pytest>=4.4.0
