Skip to content

Sliding window log issue #20

@dithya512m

Description

@dithya512m

As per the your article, the request is added to the queue even if the request isn't allowed. But in the implementation you check if the queue size is less than capacity before adding.

Your LeakyBucket and Sliding Window Log implementations are almost the same, or am I missing something? The class accepts two parameters and queue polling is the same.

Also, in leakyBucket, queue polling should be done by the server attached to rate limit?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions