Fix some of the SonarQube issues and update publish.yml

Author: jbarden

.github/workflows/publish.yml

@@ -28,5 +28,5 @@ jobs:
         run: dotnet pack ./src/${{ env.ProjectName }}/${{ env.ProjectName }}.csproj --configuration Release --output ./nupkg
 
       - name: 🚀 Publish to NuGet.org
-        run: dotnet nuget push ./nupkg/*.nupkg --skip-duplicate --source https://apiint.nugettest.org/v3/index.json --api-key ${{ secrets.NuGet_Test_API_Key }} # https://api.nuget.org/v3/index.json
+        run: dotnet nuget push ./nupkg/*.nupkg --skip-duplicate --source https://api.nuget.org/v3/index.json --api-key ${{ secrets.NuGet_Test_API_Key }} #
 

src/AStar.Dev.Functional.Extensions/AStar.Dev.Functional.Extensions.csproj

@@ -9,7 +9,7 @@
         <IncludeSymbols>true</IncludeSymbols>
         <SymbolPackageFormat>snupkg</SymbolPackageFormat>
         <PackageId>AStar.Dev.Functional.Extensions</PackageId>
-        <Version>0.2.2-alpha</Version>
+        <Version>0.3.0-alpha</Version>
         <PackageReadmeFile>Readme.md</PackageReadmeFile>
         <Authors>Jason</Authors>
         <Company>AStar Development</Company>
@@ -25,17 +25,20 @@
         <IsPackable>true</IsPackable>
         <Title>AStar.Dev.Functional.Extensions</Title>
         <Copyright>AStar Development 2025</Copyright>
-        <PackageReleaseNotes>No changes in this version, just extending the documentation</PackageReleaseNotes>
+        <PackageReleaseNotes>A complete rewrite of Result etc., and additional extensions / objects.</PackageReleaseNotes>
+        <PackageIcon>astar.png</PackageIcon>
     </PropertyGroup>
 
     <ItemGroup>
         <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All"/>
     </ItemGroup>
 
     <ItemGroup>
+        <None Include="blog-post.md" Pack="true" PackagePath="\"/>
         <None Include="Readme.md" Pack="true" PackagePath="\"/>
         <None Include="Readme-result.md" Pack="true" PackagePath="\"/>
         <None Include="Readme-option.md" Pack="true" PackagePath="\"/>
+        <None Update="astar.png" Pack="true" PackagePath="\"/>
     </ItemGroup>
 
 </Project>

src/AStar.Dev.Functional.Extensions/Option{T}.cs

@@ -36,6 +36,13 @@ public TResult Match<TResult>(Func<T, TResult> onSome, Func<TResult> onNone) =>
             _         => throw new InvalidOperationException("It should not be possible to reach this point.")
         };
 
+    /// <summary>
+    ///     Determines whether the specified object is equal to the current <see cref="Option{T}" />.
+    /// </summary>
+    /// <param name="obj">The object to compare with the current instance.</param>
+    /// <returns>
+    ///     <c>true</c> if the specified object is equal to the current instance; otherwise, <c>false</c>.
+    /// </returns>
     public override bool Equals(object? obj)
     {
         if(obj is Option<T> other)
@@ -51,6 +58,14 @@ public override bool Equals(object? obj)
         return false;
     }
 
+    /// <summary>
+    ///     Returns a hash code for the current instance of the <see cref="Option{T}" />.
+    ///     For <see cref="Option{T}.Some" />, the hash code is computed based on its type and value.
+    ///     For <see cref="Option{T}.None" />, the hash code is derived from its type.
+    /// </summary>
+    /// <returns>
+    ///     An integer representing the hash code of the current instance.
+    /// </returns>
     public override int GetHashCode() =>
         this switch
         {
@@ -59,8 +74,24 @@ public override int GetHashCode() =>
             _         => 0
         };
 
-    // Add equality operators
+    /// <summary>
+    ///     Determines whether two <see cref="Option{T}" /> instances are equal at a value level.
+    /// </summary>
+    /// <param name="left">The first <see cref="Option{T}" /> instance to compare.</param>
+    /// <param name="right">The second <see cref="Option{T}" /> instance to compare.</param>
+    /// <returns>
+    ///     True if the two <see cref="Option{T}" /> instances are considered equal; otherwise, false.
+    /// </returns>
     public static bool operator ==(Option<T> left, Option<T> right) => left.Equals(right);
+
+    /// <summary>
+    ///     Determines whether two <see cref="Option{T}" /> instances are not equal at a value level.
+    /// </summary>
+    /// <param name="left">The first <see cref="Option{T}" /> instance to compare.</param>
+    /// <param name="right">The second <see cref="Option{T}" /> instance to compare.</param>
+    /// <returns>
+    ///     <c>true</c> if the two instances are not equal; otherwise, <c>false</c>.
+    /// </returns>
     public static bool operator !=(Option<T> left, Option<T> right) => !left.Equals(right);
 
     /// <summary>

src/AStar.Dev.Functional.Extensions/astar.png

@@ -2,6 +2,9 @@ namespace AStar.Dev.Functional.Extensions.Tests.Unit;
 
 public class OptionShould
 {
+    private static readonly int[] ExpectedArrayOfInts  = [1, 2, 3];
+    private static readonly int[] ExpectedArrayOfInts2 = [20, 40];
+
     [Fact]
     public void MatchToSomeHandlerWhenOptionIsSome()
     {
@@ -649,7 +652,7 @@ public void ExtractValuesFromCollectionOfOptions()
         var result = options.Values().ToList();
 
         result.Count.ShouldBe(3);
-        result.ShouldBe(new[] { 1, 2, 3 });
+        result.ShouldBe(ExpectedArrayOfInts);
     }
 
     [Fact]
@@ -675,7 +678,7 @@ public void TransformCollectionWithChooser()
                                              : Option.None<int>()).ToList();
 
         result.Count.ShouldBe(2);
-        result.ShouldBe(new[] { 20, 40 });
+        result.ShouldBe(ExpectedArrayOfInts2);
     }
 
     [Fact]