chore: cleaning up and adding comments

Author: nishantmunjal7

application_sdk/services/secretstore.py

@@ -163,7 +163,10 @@ def _fetch_single_key_secrets(
                 single_secret = cls.get_secret(value)
                 if single_secret:
                     for k, v in single_secret.items():
-                        if not v:
+                        # Only filter out None and empty strings, not all falsy values.
+                        # This preserves valid secret values like False, 0, 0.0 which are
+                        # legitimate secret values that should not be excluded.
+                        if v is None or v == "":
                             continue
                         collected[k] = v
             except Exception as e:

tests/unit/common/test_credential_utils.py

@@ -275,6 +275,27 @@ def test_fetch_single_key_secrets_with_empty_values(self, mock_get_secret):
         assert "empty" not in result
         assert "null" not in result
 
+    @patch("application_sdk.services.secretstore.SecretStore.get_secret")
+    def test_fetch_single_key_secrets_preserves_falsy_values(self, mock_get_secret):
+        """Test that valid falsy values (False, 0) are preserved and not filtered out."""
+        credential_config = {
+            "enabled": "enabled_secret_key",
+            "port": "port_secret_key",
+            "count": "count_secret_key",
+        }
+
+        mock_get_secret.side_effect = [
+            {"enabled_secret_key": False},  # Boolean False should be preserved
+            {"port_secret_key": 0},  # Integer 0 should be preserved
+            {"count_secret_key": 0.0},  # Float 0.0 should be preserved
+        ]
+
+        result = SecretStore._fetch_single_key_secrets(credential_config)
+
+        assert result["enabled_secret_key"] is False
+        assert result["port_secret_key"] == 0
+        assert result["count_secret_key"] == 0.0
+
     @patch("application_sdk.services.secretstore.SecretStore.get_secret")
     def test_fetch_single_key_secrets_with_exceptions(self, mock_get_secret):
         """Test fetching secrets in single-key mode when some lookups fail."""