-
Notifications
You must be signed in to change notification settings - Fork 8
fix: Improve IO Abstractions and cleanup #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
inishchith
wants to merge
20
commits into
main
Choose a base branch
from
refactor/io-too
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
48d7840
feat(io): add base Reader/Writer and IOStats
inishchith fab8807
feat: refactor first draft
inishchith a2f226d
chore: cleanup
inishchith 2a3e5bf
fix: unit tests
inishchith 448c5e1
fix: results for handlers
inishchith 4aa3fe8
Merge branch 'main' into refactor/io-too
inishchith 5ae16e8
Merge branch 'main' into refactor/io-too
inishchith 7b642c1
fix: remove output_suffix from parquetwriter
inishchith fb0ffb9
chore: rename DFType to DataframeType
inishchith a98f940
Merge branch 'main' into refactor/io-too
inishchith e8712c2
chore: remove SQLQueryInput references
inishchith 6af95bb
fix: raise an error If sql_client is not provided
inishchith 0c77f42
fix: tests
inishchith bcba06c
chore: rename df_type to dataframe_type
inishchith 3d01edb
fix: rules and cleanup common/utils
inishchith 428d0f3
chore: more cleanup
inishchith 2f94c84
chore: remove docs entirely and move to atlan-docs
inishchith 5c42896
fix: mutable fields in json.py
inishchith b272529
Merge branch 'main' of github.com:atlanhq/application-sdk into refact…
abhishekagrawal-atlan 07c97ad
fix: pre-commit related errors
abhishekagrawal-atlan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we must use
write()method with dataframeType as daft