feat: Expose accumulated metrics #813
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📜 Docstring Coverage ReportRESULT: PASSED (minimum: 30.0%, actual: 75.5%) Detailed Coverage Report |
📦 Trivy Vulnerability Scan Results
Report Summary
Scan Result Details✅ No vulnerabilities found during the scan for |
📦 Trivy Secret Scan Results
Report Summary
Scan Result Details✅ No secrets found during the scan for |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Collaborator
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
|
🛠 Full Test Coverage Report: https://k.atlan.dev/coverage/application-sdk/pr/813 |
|
🛠 Docs available at: https://k.atlan.dev/application-sdk/APP-8299 |
There was a problem hiding this comment.
Bug: Update Test for File Handling Changes
The test expects file to be opened with mode "w" and path /test/path/statistics.json.ignore, but the implementation now uses mode "wb" and path /test/path/statistics/statistics.json.ignore. The test needs updating to match the new implementation.
tests/unit/outputs/test_output.py#L139-L140
application-sdk/tests/unit/outputs/test_output.py
Lines 139 to 140 in 7ecb605
📦 Example workflows test results
|
OnkarVO7
previously approved these changes
Nov 26, 2025
📦 Example workflows test results
|
📦 Example workflows test results
|
abhishekagrawal-atlan
previously approved these changes
Nov 26, 2025
anurag-atlan
dismissed stale reviews from abhishekagrawal-atlan, OnkarVO7, and akshay-vishwanath27
via
442b9e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Additional context (e.g. screenshots, logs, links)
Checklist
Copyleft License Compliance
Note
Routes typename into statistics and writes stats under output_path/statistics (with optional chunk-specific filenames), updating SQL transform call and unit tests accordingly.
Output.get_statisticsnow forwardstypenametowrite_statistics.Output.write_statistics(typename)addstypenameto the payload, writes JSON understatistics/(e.g.,statistics.json.ignoreorstatistics-chunk-{chunk_start}.json.ignore), ensures the directory exists, writes in binary mode, and uploads the new path.transform_datareturnstransformed_output.get_statistics(typename=typename).tests/unit/outputs/test_output.pyto reflect new statistics path, directory creation, file mode, and mocks.Written by Cursor Bugbot for commit ea6357b. This will update automatically on new commits. Configure here.