MLH-1226 Handle add list/set property value methods

Author: nikhilbonte21

graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusElement.java

@@ -335,7 +335,7 @@ public boolean isIdAssigned() {
         return true;
     }
 
-    private void recordInternalAttribute(String propertyName, Object finalValue) {
+    protected void recordInternalAttribute(String propertyName, Object finalValue) {
         if (propertyName.startsWith(INTERNAL_PROPERTY_KEY_PREFIX)) {
             RequestContext context = RequestContext.get();
             String entityGuid = this.getProperty(GUID_PROPERTY_KEY, String.class);
@@ -351,4 +351,69 @@ private void recordInternalAttribute(String propertyName, Object finalValue) {
             }
         }
     }
+
+    protected void recordInternalAttributeIncrementalAdd(String propertyName, Object value, Class cardinality) {
+        if (propertyName.startsWith(INTERNAL_PROPERTY_KEY_PREFIX)) {
+            String entityGuid = this.getProperty(GUID_PROPERTY_KEY, String.class);
+
+            if (StringUtils.isNotEmpty(entityGuid)) {
+                Collection<Object> currentValues = null;
+
+                if (cardinality == List.class) {
+                    currentValues = getMultiValuedProperty(propertyName, Object.class);
+                } else {
+                    currentValues = getMultiValuedSetProperty(propertyName, Object.class);
+                }
+
+                // Assumption: This method is being called after setting the property on element,
+                // hence assuming currentValues is the final expected state and not adding `value` to `currentValues`
+
+                if (StringUtils.isNotEmpty(entityGuid)) {
+                    RequestContext context = RequestContext.get();
+
+                    if (context.getAllInternalAttributesMap().get(entityGuid) != null) {
+                        context.getAllInternalAttributesMap().get(entityGuid).put(propertyName, currentValues);
+                    } else {
+                        Map<String, Object> map = new HashMap<>();
+                        map.put(propertyName, currentValues);
+                        context.getAllInternalAttributesMap().put(entityGuid, map);
+                    }
+                }
+            }
+        }
+    }
+
+    protected void recordInternalAttributeIncremental2(String propertyName, Object value, Class cardinality) {
+        if (propertyName.startsWith(INTERNAL_PROPERTY_KEY_PREFIX)) {
+            RequestContext context = RequestContext.get();
+            String entityGuid = this.getProperty(GUID_PROPERTY_KEY, String.class);
+            Collection<Object> values = null;
+
+            if (cardinality == List.class) {
+                values = new ArrayList<>();
+            } else {
+                values = new HashSet<>();
+            }
+
+            if (StringUtils.isNotEmpty(entityGuid)) {
+                if (context.getAllInternalAttributesMap().get(entityGuid) != null) {
+                    Collection<Object> currentValueInRecord = (Collection) context.getAllInternalAttributesMap().get(entityGuid).get(propertyName);
+
+                    if (currentValueInRecord == null) {
+                        values.add(value);
+                        context.getAllInternalAttributesMap().get(entityGuid).put(propertyName, values);
+                    } else {
+                        currentValueInRecord.add(value);
+                        context.getAllInternalAttributesMap().get(entityGuid).put(propertyName, currentValueInRecord);
+                    }
+                } else {
+                    values.add(value);
+
+                    Map<String, Object> map = new HashMap<>();
+                    map.put(propertyName, values);
+                    context.getAllInternalAttributesMap().put(entityGuid, map);
+                }
+            }
+        }
+    }
 }

graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusVertex.java

@@ -20,6 +20,7 @@
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Iterator;
+import java.util.List;
 import java.util.Set;
 import java.util.stream.StreamSupport;
 
@@ -55,6 +56,7 @@ public AtlasJanusVertex(AtlasJanusGraph graph, Vertex source) {
     public <T> void addProperty(String propertyName, T value) {
         try {
             getWrappedElement().property(VertexProperty.Cardinality.set, propertyName, value);
+            recordInternalAttributeIncrementalAdd(propertyName, value, Set.class);
         } catch(SchemaViolationException e) {
             throw new AtlasSchemaViolationException(e);
         }
@@ -64,6 +66,7 @@ public <T> void addProperty(String propertyName, T value) {
     public <T> void addListProperty(String propertyName, T value) {
         try {
             getWrappedElement().property(VertexProperty.Cardinality.list, propertyName, value);
+            recordInternalAttributeIncrementalAdd(propertyName, value, List.class);
         } catch(SchemaViolationException e) {
             throw new AtlasSchemaViolationException(e);
         }