atmospheric_fieldAppendAbsorptionData

[stefanbuehler]

I don't understand this method. According to documentation of atmospheric_field, it does not contain absorption data. Does it now? If yes, why, and how does this work?

[riclarsson]

The short: This method scans your absorption data and appends required data to your atmospheric field. If your CIA data contains H2O-CIA-O2, that means we need both H2O and O2 VMR. If one of your absorption lines follow the old artscat-4 format, you need self, H2O, H2, He, CO2, O2, and N2 VMR.

[stefanbuehler]

That sounds great. May I suggest to change the name to
atmospheric_fieldAppendFieldsRequiredByAbsorptionSpecies ?

The present name sounds like the absorption coefficients are somehow stored in the atmospheric field, which is confusing.

Please also add built-in documentation. It can be as short as what you wrote above.

[riclarsson]

I think you misunderstood this. Generally, you should just call atmospheric_fieldRead. This wraps what you need, which includes the method above.

Your name sounds a lot like atmospheric_fieldAppendTagsSpeciesData.

I think what's needed here is rather a tier level. You are not supposed to use the method. It's there for the composition of atmospheric_fieldRead. It's around so we can easily compose other methods.

[stefanbuehler]

That is all fine, but I think the name is very misleading. Can you please find one that matches what the function does? It is not appending absorption data.