Merge pull request #2422 from atom-community/deps

Author: aminya

.eslintignore

@@ -0,0 +1,4 @@
+{
+  "extends": "eslint-config-atomic",
+  "ignorePatterns": ["dist/", "node_modules/", "spec/fixtures", "examples", "lib/grammars/*.coffee"]
+}

.eslintrc.json

@@ -25,7 +25,7 @@ export default class CodeContextBuilder {
   //
   // returns a {CodeContext} object
   buildCodeContext(editor, argType = 'Selection Based') {
-    if (!editor) return null;
+    if (!editor) {return null;}
 
     const codeContext = this.initCodeContext(editor);
 
@@ -35,7 +35,7 @@ export default class CodeContextBuilder {
       editor.save();
     } else if (codeContext.selection.isEmpty() && codeContext.filepath) {
       codeContext.argType = 'File Based';
-      if (editor && editor.isModified()) editor.save();
+      if (editor && editor.isModified()) {editor.save();}
     }
 
     // Selection and Line Number Based runs both benefit from knowing the current line
@@ -66,9 +66,9 @@ export default class CodeContextBuilder {
 
     const codeContext = new CodeContext(filename, filepath, textSource);
     codeContext.selection = selection;
-    codeContext.shebang = this.getShebang(editor);
+    codeContext.shebang = getShebang(editor);
 
-    const lang = this.getLang(editor);
+    const lang = getLang(editor);
 
     if (this.validateLang(lang)) {
       codeContext.lang = lang;
@@ -77,18 +77,14 @@ export default class CodeContextBuilder {
     return codeContext;
   }
 
-  getShebang(editor) {
-    if (process.platform === 'win32') return null;
-    const text = editor.getText();
-    const lines = text.split('\n');
-    const firstLine = lines[0];
-    if (!firstLine.match(/^#!/)) return null;
-
-    return firstLine.replace(/^#!\s*/, '');
+  /** @deprecated use {getShebang} function */ // eslint-disable-next-line class-methods-use-this
+  getShebang(arg) {
+    return getShebang(arg);
   }
 
-  getLang(editor) {
-    return editor.getGrammar().name;
+  /** @deprecated use {getLang} function */ // eslint-disable-next-line class-methods-use-this
+  getLang(arg) {
+    return getLang(arg);
   }
 
   validateLang(lang) {
@@ -117,3 +113,17 @@ export default class CodeContextBuilder {
     return this.emitter.on('did-not-support-language', callback);
   }
 }
+
+export function getShebang(editor) {
+  if (process.platform === 'win32') {return null;}
+  const text = editor.getText();
+  const lines = text.split('\n');
+  const firstLine = lines[0];
+  if (!firstLine.match(/^#!/)) {return null;}
+
+  return firstLine.replace(/^#!\s*/, '');
+}
+
+export function getLang(editor) {
+  return editor.getGrammar().name;
+}

.eslintrc.yml

@@ -40,7 +40,7 @@ export default class CodeContext {
   // Returns the code selection {String}
   getCode(prependNewlines = true) {
     const code = this.textSource ? this.textSource.getText() : null;
-    if (!prependNewlines || !this.lineNumber) return code;
+    if (!prependNewlines || !this.lineNumber) {return code;}
 
     const newlineCount = Number(this.lineNumber);
     const newlines = Array(newlineCount).join('\n');
@@ -52,7 +52,7 @@ export default class CodeContext {
   // Returns the {String} name of the command or {undefined} if not applicable.
   shebangCommand() {
     const sections = this.shebangSections();
-    if (!sections) return null;
+    if (!sections) {return null;}
 
     return sections[0];
   }

lib/code-context-builder.js

@@ -48,23 +48,28 @@ export default class CommandContext {
     return commandContext;
   }
 
+  /** @deprecated use {quoteArguments} function */ // eslint-disable-next-line class-methods-use-this
   quoteArguments(args) {
-    return args.map((arg) => (arg.trim().indexOf(' ') === -1 ? arg.trim() : `'${arg}'`));
+    return quoteArguments(args)
   }
 
   getRepresentation() {
-    if (!this.command || !this.args.length) return '';
+    if (!this.command || !this.args.length) {return '';}
 
     // command arguments
-    const commandArgs = this.options.cmdArgs ? this.quoteArguments(this.options.cmdArgs).join(' ') : '';
+    const commandArgs = this.options.cmdArgs ? quoteArguments(this.options.cmdArgs).join(' ') : '';
 
     // script arguments
-    const args = this.args.length ? this.quoteArguments(this.args).join(' ') : '';
-    const scriptArgs = this.options.scriptArgs ? this.quoteArguments(this.options.scriptArgs).join(' ') : '';
+    const args = this.args.length ? quoteArguments(this.args).join(' ') : '';
+    const scriptArgs = this.options.scriptArgs ? quoteArguments(this.options.scriptArgs).join(' ') : '';
 
     return this.command.trim()
       + (commandArgs ? ` ${commandArgs}` : '')
       + (args ? ` ${args}` : '')
       + (scriptArgs ? ` ${scriptArgs}` : '');
   }
 }
+
+export function quoteArguments(args) {
+  return args.map((arg) => (arg.trim().indexOf(' ') === -1 ? arg.trim() : `'${arg}'`));
+}

lib/code-context.js

@@ -7,7 +7,7 @@ import path from 'path';
 import { v1 as uuidv1 } from 'uuid';
 
 // Public: GrammarUtils - utilities for determining how to run code
-export default {
+const GrammarUtils = {
   tempFilesDir: path.join(os.tmpdir(), 'atom_script_tempfiles'),
 
   // Public: Create a temporary file with the provided code
@@ -56,12 +56,11 @@ export default {
   // Public: Format args for cmd or bash, depending on the current OS
   formatArgs(command) {
     if (os.platform() === 'win32') {
-      return [`/c ${command.replace(/['"]/g, '')}`];
+      return [`/c ${command.replace(/["']/g, '')}`];
     }
     return ['-c', command];
   },
 
-  /* eslint-disable global-require */
   // Public: Get the Java helper object
   //
   // Returns an {Object} which assists in preparing java + javac statements
@@ -107,3 +106,4 @@ export default {
   // Returns an {Object} which assists in creating temp files containing D code
   D: require('./grammar-utils/d'),
 };
+export default GrammarUtils;

lib/command-context.js

@@ -1,7 +1,7 @@
 'use babel';
 
 // Public: GrammarUtils.R - a module which assist the creation of R temporary files
-export default {
+const GrammarUtilsR = {
   // Public: Create a temporary file with the provided R code
   //
   // * `code`    A {String} containing some R code
@@ -11,3 +11,4 @@ export default {
     return module.parent.exports.createTempFileWithCode(code);
   },
 };
+export default GrammarUtilsR;

lib/grammar-utils.js

@@ -7,7 +7,7 @@ import path from 'path';
 import { v1 as uuidv1 } from 'uuid';
 
 // Public: GrammarUtils.D - a module which assist the creation of D temporary files
-export default {
+const GrammarUtilsD = {
   tempFilesDir: path.join(os.tmpdir(), 'atom_script_tempfiles'),
 
   // Public: Create a temporary file with the provided D code
@@ -31,3 +31,4 @@ export default {
     }
   },
 };
+export default GrammarUtilsD;

lib/grammar-utils/R.js

@@ -4,7 +4,7 @@
 import os from 'os';
 import path from 'path';
 
-export default {
+const GrammarUtilsJava = {
   // Public: Get atom temp file directory
   //
   // Returns {String} containing atom temp file directory
@@ -47,3 +47,4 @@ export default {
     return `${filenameRemoved}.`;
   },
 };
+export default GrammarUtilsJava;