Undisable noImplicitAny
#84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
tstirrat15
force-pushed
the
undisable-no-implicit-any
branch
from
43d0eb1 to
d141dea
Compare
tstirrat15
force-pushed
the
undisable-no-implicit-any
branch
from
d141dea to
fbff958
Compare
tstirrat15
force-pushed
the
undisable-no-implicit-any
branch
from
fbff958 to
17101f6
Compare
tstirrat15
force-pushed
the
undisable-no-implicit-any
branch
from
17101f6 to
137c384
Compare
tstirrat15
force-pushed
the
undisable-no-implicit-any
branch
from
137c384 to
05ea0c2
Compare
tstirrat15
force-pushed
the
undisable-no-implicit-any
branch
from
05ea0c2 to
f075cf6
Compare
alecmerdler
reviewed
Oct 17, 2025
| }; | ||
|
|
||
| // TODO: this is creating a new `run` on every render. Refactor so that the reference is stable, | ||
| // or else use an off-the-shelf debounce. |
There was a problem hiding this comment.
tstirrat15
force-pushed
the
undisable-no-implicit-any
branch
from
f075cf6 to
4d3ebdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of getting this codebase closer to strictly following Typescript's recommendations, which provides better type-safety and ideally better behavior.
The idea behind this one is that if typescript can't infer the type of a function argument, especially in a callback function, it will type it as
any. This is the "implicit" any in the rule. This configuration change makes typescript yell at you about it.I don't think I uncovered any actual bugs here, but it means the guardrails should be better.
Changes
Will annotate.
Testing
Review. See that tests pass.