[Bug]: return in finally swallows exceptions

[iritkatriel]

Describe the bug

There are several places in your code (listed below) where there is a return statement in a finally block, which would swallow any in-flight exception.

This means that if an unhandled exception (including a BaseException such as KeyboardInterrupt) is raised from the try body, or any exception is raised from one of the except: clauses, it will not propagate on as expected.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.

autogen/autogen/logger/file_logger.py

Line 81 in faa8c7e

return self.session_id

autogen/autogen/logger/sqlite_logger.py

Line 170 in faa8c7e

return self.session_id

autogen/autogen/runtime_logging.py

Line 68 in faa8c7e

return session_id

Steps to reproduce

No response

Model Used

No response

Expected Behavior

No response

Screenshots and logs

No response

Additional Information

No response

[sonichi]

Thanks @iritkatriel . Would you like to make a PR?

[iritkatriel]

Don't wait on me, go ahead.