-
Notifications
You must be signed in to change notification settings - Fork 81
Open
Description
Hi,
In datasets.py, are you making age a dynamic covariate, instead of just using the initial value?
In that case,
auton-survival/auton_survival/datasets.py
Line 132 in 5dde465
| age = data['age'] + data['years'] |
should change to
age = data['age'] + data['year']years is the time of the event. year is the time indicator.
Here are some results:
Current:
In: x, t, e = datasets.load_dataset('PBC', sequential = True)
In: x[0][0][-1]
Out: 59.86200854232829
In: x[0][1][-1]
Out: 59.86200854232829After the proposed change:
In: x, t, e = datasets.load_dataset('PBC', sequential = True)
In: x[0][0][-1]
Out: 58.7668382433468
In: x[0][1][-1]
Out: 59.29251998685791I have tested this on the DeepSurvivalMachine package, but I believe this package uses the same module for loading datasets. I can redo these tests, and do a pull request if needed.
matteo4diani
Metadata
Metadata
Assignees
Labels
No labels