Skip to content

Conversation

@sobolk
Copy link
Contributor

@sobolk sobolk commented Sep 17, 2024

Problem

Canaries started to fail https://github.com/aws-amplify/amplify-backend/actions/runs/10893420780/job/30228299757 .

The change is not breaking, but we should catch up.

Changes

  1. Update data-construct dependency
  2. Adjust tests.

Validation

Canary run: https://github.com/aws-amplify/amplify-backend/actions/runs/10905264373

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk requested review from a team as code owners September 17, 2024 14:34
@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: df8130b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/backend-data Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

':apis/',
{
'Fn::GetAtt': ['amplifyDataGraphQLAPI42A6FA33', 'ApiId'],
'Fn::GetAtt': ['amplifyDataGraphQLAPI42A6FA33', 'Arn'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so ApiId is no longer available from the nested stack? Why is this not breaking change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not that it's not available.

Data construct just changed how do they obtain arn for policy statement.

I.e. instead of formatting arn themselves from other attributes they read this field now https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_appsync.CfnGraphQLApi.html#attrarn .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which in turn affected the assertion. runtime behavior should be same.

@sobolk sobolk enabled auto-merge (squash) September 17, 2024 14:48
@sobolk sobolk merged commit ffc3b42 into main Sep 17, 2024
@sobolk sobolk deleted the update-data-construct branch September 17, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants