Skip to content

Conversation

@ShadowCat567
Copy link
Contributor

@ShadowCat567 ShadowCat567 commented Sep 25, 2024

BRANCH DID NOT ORIGINATE FROM MAIN

Problem

npm:stop-proxy command was unable to be run without an error on Windows, so verdaccio process could not be killed. This stems from lsof command not existing on Windows.
Issue number, if available: N/A

Changes

  • Added check to see if user is running stop-npm-proxy.ts on Windows machine
  • if user is using Windows machine, uses alternative command to find PID of verdaccio so the process can be killed
    Corresponding docs PR, if applicable:

Validation

Checked that process running on verdaccio port is killed after stop:npm-proxy command is run

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Vieltojarvi and others added 23 commits August 26, 2024 08:56
@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2024

⚠️ No Changeset found

Latest commit: 5a6222b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ShadowCat567 ShadowCat567 deleted the Stop-Proxy-Win branch September 25, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant