Update to stop:npm-proxy for Windows
#2053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sobolk
previously approved these changes
Sep 25, 2024
scripts/stop_npm_proxy.ts
Outdated
| if (process.platform === 'win32') { | ||
| const netStatResult = await execaCommand( | ||
| `netstat -n -a -o | grep ${VERDACCIO_PORT}`, | ||
| { shell: true } |
There was a problem hiding this comment.
is this going to work in Powershell ?
if not then consider shell: 'bash'.
There was a problem hiding this comment.
grep command does not work in Powershell (also doesn't work in command prompt), I'll update that
sobolk
approved these changes
Sep 25, 2024
awsluja
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
npm:stop-proxycommand was unable to be run without an error on Windows, so verdaccio process could not be killed. This stems fromlsofcommand not existing on Windows.Issue number, if available:
Changes
stop-npm-proxy.tson Windows machinenetstatwas the best equivalent tolsofthat I could find for windows) to find PID of verdaccio so the process can be killedCorresponding docs PR, if applicable:
Validation
Checked that process running on verdaccio port is killed after
stop:npm-proxycommand is runChecklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.