Ensure we are getting FileEntry
type
#2980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
@zip.js/zip.js
released a new version where they removed thegetData
property from theDirectoryEntry
type. TheDirectoryEntry
type is part of the type union that makes up the typeEntry
. Since we do ensure we are gettingFileEntry
in this integration test, then the removal of thegetData
field from theDirectoryEntry
type means that typescript isn't sure whether we have aFileEntry
or aDirectoryEntry
when we get toentry.getData!(new TextWriter())
so it throws an error becausegetData
is only defined for theFileEntry
type.Issue number, if available:
Changes
Since we are expecting the file
index.mjs
to have typeFileEntry
, we assert that the directory property is set to false.Corresponding docs PR, if applicable:
Validation
Successful canary run: https://github.com/aws-amplify/amplify-backend/actions/runs/17562239264
Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.