Skip to content

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Sep 22, 2025

Problem

Our CI currently incorrectly detects breaking changes on all PRs. This is because TypeScript 5.9 made some changes to the default config when running tsc --init.

Changes

Explicitly set required TS config. Also pinning the version of TS since I don't see why the auto upgrade would be important.

Validation

CI passes.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mrgrain mrgrain requested a review from a team as a code owner September 22, 2025 14:36
Copy link

changeset-bot bot commented Sep 22, 2025

🦋 Changeset detected

Latest commit: cda6dad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ShadowCat567
ShadowCat567 previously approved these changes Sep 22, 2025
rix0rrr
rix0rrr previously approved these changes Sep 22, 2025
@mrgrain mrgrain dismissed stale reviews from rix0rrr and ShadowCat567 via 2c3ca5c September 22, 2025 15:44
@mrgrain mrgrain merged commit 83d5962 into main Sep 22, 2025
52 checks passed
@mrgrain mrgrain deleted the mrgrain/chore/no-breaking-api-changes branch September 22, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants