Skip to content

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Sep 25, 2025

Problem

The e2e resource cleanup workflow can occasionally fail due to transient issues, causing resource cleanup to be incomplete.

Changes

  • Added retry logic using nick-fields/retry action with 3 attempts
  • Set 60-second wait between retries and 15-minute timeout
  • Maintains existing cleanup command while adding resilience

Validation

This change improves the reliability of the cleanup process without affecting the core functionality. The retry action is a well-established GitHub action used across many repositories.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mrgrain mrgrain requested a review from a team as a code owner September 25, 2025 09:36
Copy link

changeset-bot bot commented Sep 25, 2025

🦋 Changeset detected

Latest commit: 52f5b91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrgrain mrgrain changed the title feat: add retry logic to e2e resource cleanup workflow chore: add retry logic to e2e resource cleanup workflow Sep 25, 2025
@mrgrain mrgrain requested a review from a team as a code owner September 25, 2025 09:36
@mrgrain mrgrain enabled auto-merge (squash) September 25, 2025 09:46
@mrgrain mrgrain merged commit 4782afa into main Sep 25, 2025
51 checks passed
@mrgrain mrgrain deleted the mrgrain/feat/e2e-cleanup-retry branch September 25, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants