Skip to content

Conversation

iankhou
Copy link
Contributor

@iankhou iankhou commented Oct 7, 2025

Problem

Screenshot 2025-10-07 at 11 55 40

The check_api_changes job is sometimes cancelled when the job exceeds the timeout of 20 minutes. This can happen when steps are retried (introduced in #3010).

Changes

Increased the timeout from 20 minutes to 60 minutes. Being generous here, as a successful run of step Check API changes with retry should take around 14 minutes. If we try that step three times, a 60 min timeout should be able to cover the time needed for 3 tries and other steps in the run.

Validation

Run workflows on this PR.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iankhou iankhou self-assigned this Oct 7, 2025
Copy link

changeset-bot bot commented Oct 7, 2025

⚠️ No Changeset found

Latest commit: a799779

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@iankhou iankhou marked this pull request as ready for review October 7, 2025 15:57
@iankhou iankhou requested a review from a team as a code owner October 7, 2025 15:57
@iankhou iankhou force-pushed the iankhou-check-api-changes-timeout branch from 6714bba to 4ec9050 Compare October 7, 2025 16:08
@iankhou iankhou changed the title chore: increase timeout from 20 -> 30 mins for 'Check API changes with retry' chore: increase timeout from 20 -> 60 mins for 'Check API changes with retry' Oct 7, 2025
@iankhou iankhou force-pushed the iankhou-check-api-changes-timeout branch from 4ec9050 to a799779 Compare October 7, 2025 16:44
@iankhou iankhou changed the title chore: increase timeout from 20 -> 60 mins for 'Check API changes with retry' chore: increase timeout from 20 -> 60 mins for check_api_changes Oct 7, 2025
@iankhou iankhou changed the title chore: increase timeout from 20 -> 60 mins for check_api_changes fix: check_api_changes times out when steps are retried Oct 7, 2025
- name: Check API changes with retry
uses: nick-fields/retry@v3
with:
timeout_minutes: 20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this can run 3 times, we need the timeout for the job to be ~3x this.

@iankhou iankhou merged commit 6e0027d into main Oct 7, 2025
52 checks passed
@iankhou iankhou deleted the iankhou-check-api-changes-timeout branch October 7, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants