Rename ErrorType exception properties to avoid hiding inherited member

Author: muhammad-othman

generator/.DevConfigs/e2fd4917-66af-4f7a-a019-8c8fec7a1899.json

@@ -0,0 +1,13 @@
+
+
+{
+  "services": [
+    {
+      "serviceName": "Account",
+      "type": "patch",
+      "changeLogMessages": [
+        "Rename internal exception property to avoid hiding inherited AmazonServiceException member."
+      ]
+    }
+  ]
+}

generator/ServiceClientGeneratorLib/Member.cs

@@ -237,6 +237,11 @@ public string BasePropertyName
                     }
                 }
 
+                var propertyNameOverride = GetPropertyNameOverride();
+                if (!string.IsNullOrEmpty(propertyNameOverride))
+                    return propertyNameOverride;
+
+
                 return _name.ToUpperFirstCharacter();
             }
         }
@@ -482,6 +487,22 @@ public string DetermineType()
             return DetermineType(this.data, false);
         }
 
+        /// <summary>
+        /// Retrieves a property name override for specific member names that require special handling
+        /// during code generation to avoid naming conflicts or improve API consistency.
+        /// </summary>
+        /// <returns>
+        /// A string containing the overridden property name if a special case applies,
+        /// or null if the default property name should be used.
+        /// </returns>
+        private string GetPropertyNameOverride()
+        {
+            if (OwningShape.IsException && _name.ToUpperFirstCharacter() == "ErrorType")
+                return "RequestErrorType";
+
+            return null;
+        }
+
         /// <summary>
         /// Determines the type of the member based on customizations, if it isn't custom then it pulls 
         /// from the full json model to get the shape of this member

generator/ServiceModels/account/account.customizations.json

@@ -38,7 +38,7 @@ namespace Amazon.Account.Model
     #endif
     public partial class AccessDeniedException : AmazonAccountException
     {
-        private string _requestErrorType;
+        private string _errorType;
 
         /// <summary>
         /// Constructs a new AccessDeniedException with the specified error
@@ -128,14 +128,14 @@ public override void GetObjectData(System.Runtime.Serialization.SerializationInf
         /// </summary>
         public string RequestErrorType
         {
-            get { return this._requestErrorType; }
-            set { this._requestErrorType = value; }
+            get { return this._errorType; }
+            set { this._errorType = value; }
         }
 
         // Check to see if RequestErrorType property is set
         internal bool IsSetRequestErrorType()
         {
-            return this._requestErrorType != null;
+            return this._errorType != null;
         }
 
     }

sdk/src/Services/Account/Generated/Model/AccessDeniedException.cs

@@ -40,7 +40,7 @@ namespace Amazon.Account.Model
     #endif
     public partial class ConflictException : AmazonAccountException
     {
-        private string _requestErrorType;
+        private string _errorType;
 
         /// <summary>
         /// Constructs a new ConflictException with the specified error
@@ -130,14 +130,14 @@ public override void GetObjectData(System.Runtime.Serialization.SerializationInf
         /// </summary>
         public string RequestErrorType
         {
-            get { return this._requestErrorType; }
-            set { this._requestErrorType = value; }
+            get { return this._errorType; }
+            set { this._errorType = value; }
         }
 
         // Check to see if RequestErrorType property is set
         internal bool IsSetRequestErrorType()
         {
-            return this._requestErrorType != null;
+            return this._errorType != null;
         }
 
     }

sdk/src/Services/Account/Generated/Model/ConflictException.cs

@@ -38,7 +38,7 @@ namespace Amazon.Account.Model
     #endif
     public partial class InternalServerException : AmazonAccountException
     {
-        private string _requestErrorType;
+        private string _errorType;
 
         private RetryableDetails _retryableDetails = new RetryableDetails(false);
 
@@ -130,14 +130,14 @@ public override void GetObjectData(System.Runtime.Serialization.SerializationInf
         /// </summary>
         public string RequestErrorType
         {
-            get { return this._requestErrorType; }
-            set { this._requestErrorType = value; }
+            get { return this._errorType; }
+            set { this._errorType = value; }
         }
 
         // Check to see if RequestErrorType property is set
         internal bool IsSetRequestErrorType()
         {
-            return this._requestErrorType != null;
+            return this._errorType != null;
         }
 
         /// <summary>

sdk/src/Services/Account/Generated/Model/InternalServerException.cs

@@ -37,7 +37,7 @@ namespace Amazon.Account.Model
     #endif
     public partial class ResourceNotFoundException : AmazonAccountException
     {
-        private string _requestErrorType;
+        private string _errorType;
 
         /// <summary>
         /// Constructs a new ResourceNotFoundException with the specified error
@@ -127,14 +127,14 @@ public override void GetObjectData(System.Runtime.Serialization.SerializationInf
         /// </summary>
         public string RequestErrorType
         {
-            get { return this._requestErrorType; }
-            set { this._requestErrorType = value; }
+            get { return this._errorType; }
+            set { this._errorType = value; }
         }
 
         // Check to see if RequestErrorType property is set
         internal bool IsSetRequestErrorType()
         {
-            return this._requestErrorType != null;
+            return this._errorType != null;
         }
 
     }

sdk/src/Services/Account/Generated/Model/ResourceNotFoundException.cs

@@ -38,7 +38,7 @@ namespace Amazon.Account.Model
     #endif
     public partial class TooManyRequestsException : AmazonAccountException
     {
-        private string _requestErrorType;
+        private string _errorType;
 
         private RetryableDetails _retryableDetails = new RetryableDetails(true);
 
@@ -130,14 +130,14 @@ public override void GetObjectData(System.Runtime.Serialization.SerializationInf
         /// </summary>
         public string RequestErrorType
         {
-            get { return this._requestErrorType; }
-            set { this._requestErrorType = value; }
+            get { return this._errorType; }
+            set { this._errorType = value; }
         }
 
         // Check to see if RequestErrorType property is set
         internal bool IsSetRequestErrorType()
         {
-            return this._requestErrorType != null;
+            return this._errorType != null;
         }
 
         /// <summary>