Skip to content

Commit 4063499

Browse files
Merge master into feature/v2-to-v3-migration
2 parents ef15940 + 283311a commit 4063499

File tree

1 file changed

+1
-12
lines changed

1 file changed

+1
-12
lines changed

packages/core/src/auth/sso/clients.ts

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import { getLogger } from '../../shared/logger/logger'
3030
import { SsoAccessTokenProvider } from './ssoAccessTokenProvider'
3131
import { AwsClientResponseError, isClientFault } from '../../shared/errors'
3232
import { DevSettings } from '../../shared/settings'
33-
import { SdkError } from '@aws-sdk/types'
3433
import { HttpRequest, HttpResponse } from '@smithy/protocol-http'
3534
import { StandardRetryStrategy, defaultRetryDecider } from '@smithy/middleware-retry'
3635
import { AuthenticationFlow } from './model'
@@ -104,22 +103,12 @@ export class OidcClient {
104103
}
105104

106105
public static create(region: string) {
107-
const updatedRetryDecider = (err: SdkError) => {
108-
if (defaultRetryDecider(err)) {
109-
return true
110-
}
111-
112-
// As part of SIM IDE-10703, there was an assumption that retrying on InvalidGrantException
113-
// may be useful. This may not be the case anymore and if more research is done, this may not be needed.
114-
// TODO: setup some telemetry to see if there are any successes on a subsequent retry for this case.
115-
return err.name === 'InvalidGrantException'
116-
}
117106
const client = new SSOOIDC({
118107
region,
119108
endpoint: DevSettings.instance.get('endpoints', {})['ssooidc'],
120109
retryStrategy: new StandardRetryStrategy(
121110
() => Promise.resolve(3), // Maximum number of retries
122-
{ retryDecider: updatedRetryDecider }
111+
{ retryDecider: defaultRetryDecider }
123112
),
124113
customUserAgent: getUserAgent({ includePlatform: true, includeClientId: true }),
125114
requestHandler: {

0 commit comments

Comments
 (0)