Skip to content

Conversation

@rh101
Copy link
Contributor

@rh101 rh101 commented Sep 24, 2025

Describe your changes

If the application is closed during certain scene transitions, such as TransitionFade, the application will crash in Node::~Node() since the incoming scene is still active (Node::_running == true). This is due to the Node::onExit() not being called on the incoming scene in the transition.

This PR address that issue, by making it the responsibility of the transition to ensure that the incoming scene is correctly deactivated (Node::_running == false) if it detects that the Director has been reset, meaning that the app is shutting down.

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

Axmol 3.x ------------------------------------------------------------

For each 3.x PR

  • Check the '#include "axmol.h"' and replace it with the needed headers.

@rh101 rh101 closed this Sep 24, 2025
@rh101
Copy link
Contributor Author

rh101 commented Sep 24, 2025

Incorrect base branch. Will create another PR

@rh101 rh101 deleted the transition-crash-fix branch September 24, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant