Skip to content

Conversation

@aismann
Copy link
Contributor

@aismann aismann commented Sep 30, 2025

Describe your changes

see diff

  1. Missed: PixelFormat::RGB8 returns POSITION_TEXTURE_COLOR
  2. Maybe Im wrong, but I think RGBA8 should return "POSITION_TEXTURE_COLOR_ALPHA_TEST"

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

Axmol 3.x ------------------------------------------------------------

For each 3.x PR

  • Check the '#include "axmol.h"' and replace it with the needed headers.

@aismann
Copy link
Contributor Author

aismann commented Sep 30, 2025

@halx99
I also think it's time to rename ‘POSITION_TEXTURE_COLOR_ALPHA_TEST’ to ‘POSITION_TEXTURE_COLOR_ALPHA’
and all related files (shaders). (Before it gets forgotten).

@halx99
Copy link
Collaborator

halx99 commented Oct 1, 2025

@halx99 I also think it's time to rename ‘POSITION_TEXTURE_COLOR_ALPHA_TEST’ to ‘POSITION_TEXTURE_COLOR_ALPHA’ and all related files (shaders). (Before it gets forgotten).

No, the semantic not same: https://github.com/axmolengine/axmol/blob/dev/axmol/renderer/shaders/positionTextureColorAlphaTest.frag

@halx99
Copy link
Collaborator

halx99 commented Oct 1, 2025

And this PR incorrect

@aismann
Copy link
Contributor Author

aismann commented Oct 1, 2025

And this PR incorrect

I close this PR.

@aismann aismann closed this Oct 1, 2025
@aismann aismann deleted the chooseSpriteProgramType_PixelFormat_RGB8 branch October 1, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants