Skip to content

Commit b8ff66f

Browse files
authored
[engSys] Bump min-version of node to 20 (Azure#34773)
This pull request updates the Node.js version requirement across multiple files and tools in the repository. The changes ensure compatibility with Node.js version 20 and its corresponding type definitions, replacing the previous requirement for Node.js version 18. ### Node.js version updates: * [`.github/workflows/copilot-setup-steps.yml`](diffhunk://#diff-98dad98422cf59793a353f9b6bfe6a129977e92af3d5b4e38f98ae45bcb7560dL24-R24): Updated the Node.js setup step to install version 20 instead of 18. * [`common/tools/dev-tool/package.json`](diffhunk://#diff-166913d39463525ab279e0a64fe3aa2c38d6283139f024b36f7da7ffed51f466L72-R72): Changed the `@types/node` dependency to version 20.0.0. * [`common/tools/dev-tool/src/checks/packageJson.ts`](diffhunk://#diff-d41378520d18f30157b1619d5e5e2d8e80bf01d5fa46437b91c6c8fe940c46f4L13-R13): Updated the `LTS_ENGINES` constant to require Node.js version `>=20.0.0`. * [`common/tools/dev-tool/src/util/samples/configuration.ts`](diffhunk://#diff-e040a7476b6483b67f04ceecc9114851e313509103c7be1e4dbdb84afa924dddL11-R11): Updated the `MIN_SUPPORTED_NODE_VERSION` constant to `20.0.0`. ### Updates to sample expectations: * Multiple `package.json` files for JavaScript and TypeScript samples across various directories were updated to specify `"node": ">=20.0.0"` in the `engines` field and to use `@types/node` version `^20.0.0`. [[1]](diffhunk://#diff-f0ad0f2ab1c38b32bb83ab42a9f91d911766352fe5ef6f9d0d2a2213a3459883L7-R7) [[2]](diffhunk://#diff-e0c6ce163891c33d7a73c69ec934b159d2aa22c6b0351b51ecf7188f18b735d0L7-R7) [[3]](diffhunk://#diff-e0c6ce163891c33d7a73c69ec934b159d2aa22c6b0351b51ecf7188f18b735d0L34-R34) [[4]](diffhunk://#diff-1f432be2a8ceba6f2c09c0d2cf931556e4470afaff7168fc32edd5b081edd7ebL7-R7) [[5]](diffhunk://#diff-567c632dfaf389684bb26a2b6258da8e9437037c2894e12851148a2fccea0945L7-R7) [[6]](diffhunk://#diff-567c632dfaf389684bb26a2b6258da8e9437037c2894e12851148a2fccea0945L32-R32) [[7]](diffhunk://#diff-fefd46248c1837c12e71967cfd2dee060fc6879c8cf5fcae908d0aad748d3081L7-R7) [[8]](diffhunk://#diff-c61074406618dd0888e4ff3958c39f18b7f82f6aa9d2bdac3c6feed366a9e343L7-R7) [[9]](diffhunk://#diff-c61074406618dd0888e4ff3958c39f18b7f82f6aa9d2bdac3c6feed366a9e343L32-R32) [[10]](diffhunk://#diff-2fe86509406b9ddba8c13b082731ddc7ad654a3e9fc5a8c1f95804b5753b3122L7-R7) [[11]](diffhunk://#diff-bb58485baa5844d5523a219a53618f5be41232ae9cbcede8a0b0e05a3e38ebb9L7-R7) [[12]](diffhunk://#diff-bb58485baa5844d5523a219a53618f5be41232ae9cbcede8a0b0e05a3e38ebb9L32-R32) [[13]](diffhunk://#diff-bb7dd1e1bb67c9eae3c7302da13a260c179e1fe42ceb09a4116636bf574db873L7-R7) [[14]](diffhunk://#diff-49f1bee9a528694c5fe5919789597da71fceab06d1203104b7c6e33b57814480L7-R7) [[15]](diffhunk://#diff-49f1bee9a528694c5fe5919789597da71fceab06d1203104b7c6e33b57814480L32-R32) ### Updates to tools: * [`common/tools/eslint-plugin-azure-sdk/package.json`](diffhunk://#diff-406d8083a1aed239689aac864a26d5c56df5405c190d28f56937f5dde016d349L80-R80): Updated the `engines.node` field to `>=20.0.0` and changed `@types/node` to version `^20.0.0`. [[1]](diffhunk://#diff-406d8083a1aed239689aac864a26d5c56df5405c190d28f56937f5dde016d349L80-R80) [[2]](diffhunk://#diff-406d8083a1aed239689aac864a26d5c56df5405c190d28f56937f5dde016d349L108-R108) * [`common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-engine-is-present.ts`](diffhunk://#diff-94b347091321583470b131968952f68325c6fd35845ccd7496014f81229a4cd4L21-R21): Updated the `LTS` constant to `>=20.0.0`. * [`common/tools/mcp-server/package.json`](diffhunk://#diff-c3e2299b91d1e02aa40ecd2fa4f48d06a68e054be3b736dcaae34ab1d9c369ceL33-R33): Updated the `engines.node` field and `@types/node` dependency to reflect Node.js version 20. [[1]](diffhunk://#diff-c3e2299b91d1e02aa40ecd2fa4f48d06a68e054be3b736dcaae34ab1d9c369ceL33-R33) [[2]](diffhunk://#diff-c3e2299b91d1e02aa40ecd2fa4f48d06a68e054be3b736dcaae34ab1d9c369ceL58-R58) * [`common/tools/vite-plugin-browser-test-map/package.json`](diffhunk://#diff-36da0ec04a470fcc51096cd2b7c7f9cbd97232042eb4f6c96466c6a2838dd2ecL45-R52): Updated the `engines.node` field and `@types/node` dependency to version 20. Partially resolves Azure#33017
1 parent e39ec65 commit b8ff66f

File tree

1,243 files changed

+3361
-3445
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,243 files changed

+3361
-3445
lines changed

.github/workflows/copilot-setup-steps.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Set up Node.js
2222
uses: actions/setup-node@v4
2323
with:
24-
node-version: "18"
24+
node-version: "20"
2525

2626
- name: Install Rush
2727
run: npm install -g @microsoft/rush

common/config/rush/pnpm-lock.yaml

Lines changed: 1294 additions & 1372 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

common/tools/dev-tool/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
"@types/express-serve-static-core": "^5.0.6",
7070
"@types/fs-extra": "^11.0.4",
7171
"@types/minimist": "^1.2.5",
72-
"@types/node": "^18.0.0",
72+
"@types/node": "^20.0.0",
7373
"@types/semver": "^7.7.0",
7474
"@types/unzipper": "~0.10.11",
7575
"@vitest/coverage-istanbul": "^3.0.9",

common/tools/dev-tool/src/checks/packageJson.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { resolveRoot } from "../util/resolveProject";
1010
/**
1111
* Expected value for engines field
1212
*/
13-
const LTS_ENGINES = ">=18.0.0";
13+
const LTS_ENGINES = ">=20.0.0";
1414

1515
export const license = packageJsonCheck({
1616
description: 'License field in package.json must be set to "MIT"',

common/tools/dev-tool/src/util/samples/configuration.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { METADATA_KEY } from "../resolveProject";
88
* The oldest Node version that we guarantee sample programs will support.
99
* Samples may support older versions, but must support at least this version.
1010
*/
11-
export const MIN_SUPPORTED_NODE_VERSION = "18.0.0";
11+
export const MIN_SUPPORTED_NODE_VERSION = "20.0.0";
1212

1313
/**
1414
* An interface for the sample configuration metadata within an Azure SDK for

common/tools/dev-tool/test/samples/files/expectations/cjs-forms/javascript/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"version": "1.0.0",
55
"description": "CommonJS client library samples for JavaScript",
66
"engines": {
7-
"node": ">=18.0.0"
7+
"node": ">=20.0.0"
88
},
99
"repository": {
1010
"type": "git",

common/tools/dev-tool/test/samples/files/expectations/cjs-forms/typescript/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"version": "1.0.0",
55
"description": "CommonJS client library samples for TypeScript",
66
"engines": {
7-
"node": ">=18.0.0"
7+
"node": ">=20.0.0"
88
},
99
"scripts": {
1010
"build": "tsc",
@@ -31,7 +31,7 @@
3131
"@azure-test2/test2": "next"
3232
},
3333
"devDependencies": {
34-
"@types/node": "^18.0.0",
34+
"@types/node": "^20.0.0",
3535
"typescript": "~5.8.2",
3636
"rimraf": "latest"
3737
}

common/tools/dev-tool/test/samples/files/expectations/output-customization/javascript/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"version": "1.0.0",
55
"description": "Azure Template client library samples for JavaScript",
66
"engines": {
7-
"node": ">=18.0.0"
7+
"node": ">=20.0.0"
88
},
99
"repository": {
1010
"type": "git",

common/tools/dev-tool/test/samples/files/expectations/output-customization/typescript/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"version": "1.0.0",
55
"description": "Azure Template client library samples for TypeScript",
66
"engines": {
7-
"node": ">=18.0.0"
7+
"node": ">=20.0.0"
88
},
99
"scripts": {
1010
"build": "tsc",
@@ -29,7 +29,7 @@
2929
"dotenv": "latest"
3030
},
3131
"devDependencies": {
32-
"@types/node": "^18.0.0",
32+
"@types/node": "^20.0.0",
3333
"typescript": "~5.8.2",
3434
"rimraf": "latest"
3535
}

common/tools/dev-tool/test/samples/files/expectations/simple/javascript/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"version": "1.0.0",
55
"description": "Azure Template client library samples for JavaScript",
66
"engines": {
7-
"node": ">=18.0.0"
7+
"node": ">=20.0.0"
88
},
99
"repository": {
1010
"type": "git",

0 commit comments

Comments
 (0)