fix: make async versions of WaitForX methods public

fixes #1769

Author: egil

src/bunit/Extensions/WaitForHelpers/RenderedComponentWaitForHelperExtensions.WaitForElement.cs

@@ -91,7 +91,7 @@ public static IReadOnlyList<IElement> WaitForElements<TComponent>(this IRendered
 	/// <param name="cssSelector">The CSS selector to use to search for the element.</param>
 	/// <exception cref="WaitForFailedException">Thrown if no elements is found matching the <paramref name="cssSelector"/> within the default timeout. See the inner exception for details.</exception>
 	/// <returns>The <see cref="IElement"/>.</returns>
-	internal static Task<IElement> WaitForElementAsync<TComponent>(this IRenderedComponent<TComponent> renderedComponent, string cssSelector)
+	public static Task<IElement> WaitForElementAsync<TComponent>(this IRenderedComponent<TComponent> renderedComponent, string cssSelector)
 		where TComponent : IComponent => WaitForElementCoreAsync(renderedComponent, cssSelector, timeout: null);
 
 	/// <summary>
@@ -103,7 +103,7 @@ internal static Task<IElement> WaitForElementAsync<TComponent>(this IRenderedCom
 	/// <param name="timeout">The maximum time to wait for the element to appear.</param>
 	/// <exception cref="WaitForFailedException">Thrown if no elements is found matching the <paramref name="cssSelector"/> within the default timeout. See the inner exception for details.</exception>
 	/// <returns>The <see cref="IElement"/>.</returns>
-	internal static Task<IElement> WaitForElementAsync<TComponent>(this IRenderedComponent<TComponent> renderedComponent, string cssSelector, TimeSpan timeout)
+	public static Task<IElement> WaitForElementAsync<TComponent>(this IRenderedComponent<TComponent> renderedComponent, string cssSelector, TimeSpan timeout)
 		where TComponent : IComponent
 		=> WaitForElementCoreAsync(renderedComponent, cssSelector, timeout: timeout);
 
@@ -116,7 +116,7 @@ internal static Task<IElement> WaitForElementAsync<TComponent>(this IRenderedCom
 	/// <param name="matchElementCount">The exact number of elements to that the <paramref name="cssSelector"/> should match.</param>
 	/// <exception cref="WaitForFailedException">Thrown if no elements is found matching the <paramref name="cssSelector"/> within the default timeout.</exception>
 	/// <returns>The <see cref="IReadOnlyList{IElement}"/>.</returns>
-	internal static Task<IReadOnlyList<IElement>> WaitForElementsAsync<TComponent>(this IRenderedComponent<TComponent> renderedComponent, string cssSelector, int matchElementCount)
+	public static Task<IReadOnlyList<IElement>> WaitForElementsAsync<TComponent>(this IRenderedComponent<TComponent> renderedComponent, string cssSelector, int matchElementCount)
 		where TComponent : IComponent
 		=> WaitForElementsCoreAsync(renderedComponent, cssSelector, matchElementCount: matchElementCount, timeout: null);
 
@@ -129,7 +129,7 @@ internal static Task<IReadOnlyList<IElement>> WaitForElementsAsync<TComponent>(t
 	/// <param name="timeout">The maximum time to wait for elements to appear.</param>
 	/// <exception cref="WaitForFailedException">Thrown if no elements is found matching the <paramref name="cssSelector"/> within the default timeout.</exception>
 	/// <returns>The <see cref="IReadOnlyList{IElement}"/>.</returns>
-	internal static Task<IReadOnlyList<IElement>> WaitForElementsAsync<TComponent>(this IRenderedComponent<TComponent> renderedComponent, string cssSelector, TimeSpan timeout)
+	public static Task<IReadOnlyList<IElement>> WaitForElementsAsync<TComponent>(this IRenderedComponent<TComponent> renderedComponent, string cssSelector, TimeSpan timeout)
 		where TComponent : IComponent
 		=> WaitForElementsCoreAsync(renderedComponent, cssSelector, matchElementCount: null, timeout: timeout);
 
@@ -143,7 +143,7 @@ internal static Task<IReadOnlyList<IElement>> WaitForElementsAsync<TComponent>(t
 	/// <param name="timeout">The maximum time to wait for elements to appear.</param>
 	/// <exception cref="WaitForFailedException">Thrown if no elements is found matching the <paramref name="cssSelector"/> within the default timeout.</exception>
 	/// <returns>The <see cref="IReadOnlyList{IElement}"/>.</returns>
-	internal static Task<IReadOnlyList<IElement>> WaitForElementsAsync<TComponent>(this IRenderedComponent<TComponent> renderedComponent, string cssSelector, int matchElementCount, TimeSpan timeout)
+	public static Task<IReadOnlyList<IElement>> WaitForElementsAsync<TComponent>(this IRenderedComponent<TComponent> renderedComponent, string cssSelector, int matchElementCount, TimeSpan timeout)
 		where TComponent : IComponent
 		=> WaitForElementsCoreAsync(renderedComponent, cssSelector, matchElementCount: matchElementCount, timeout: timeout);
 
@@ -155,7 +155,7 @@ internal static Task<IReadOnlyList<IElement>> WaitForElementsAsync<TComponent>(t
 	/// <param name="cssSelector">The CSS selector to use to search for elements.</param>
 	/// <exception cref="WaitForFailedException">Thrown if no elements is found matching the <paramref name="cssSelector"/> within the default timeout.</exception>
 	/// <returns>The <see cref="IReadOnlyList{IElement}"/>.</returns>
-	internal static Task<IReadOnlyList<IElement>> WaitForElementsAsync<TComponent>(this IRenderedComponent<TComponent> renderedComponent, string cssSelector)
+	public static Task<IReadOnlyList<IElement>> WaitForElementsAsync<TComponent>(this IRenderedComponent<TComponent> renderedComponent, string cssSelector)
 		where TComponent : IComponent
 		=> WaitForElementsCoreAsync<TComponent>(renderedComponent, cssSelector, matchElementCount: null, timeout: null);
 
@@ -166,7 +166,7 @@ private static IElement WaitForElementCore<TComponent>(this IRenderedComponent<T
 
 		try
 		{
-			return waiter.WaitTask.GetAwaiter().GetResult();
+			return waiter.WaitTask.ConfigureAwait(false).GetAwaiter().GetResult();
 		}
 		catch (AggregateException e) when (e.InnerExceptions.Count == 1)
 		{
@@ -196,7 +196,7 @@ private static IReadOnlyList<IElement> WaitForElementsCore<TComponent>(
 
 		try
 		{
-			return waiter.WaitTask.GetAwaiter().GetResult();
+			return waiter.WaitTask.ConfigureAwait(false).GetAwaiter().GetResult();
 		}
 		catch (AggregateException e) when (e.InnerExceptions.Count == 1)
 		{

src/bunit/Extensions/WaitForHelpers/RenderedComponentWaitForHelperExtensions.WaitForState.cs

@@ -30,7 +30,7 @@ public static void WaitForState<TComponent>(this IRenderedComponent<TComponent>
 
 			try
 			{
-				waiter.WaitTask.GetAwaiter().GetResult();
+				waiter.WaitTask.ConfigureAwait(false).GetAwaiter().GetResult();
 			}
 			catch (AggregateException e) when (e.InnerExceptions.Count == 1)
 			{
@@ -49,11 +49,10 @@ public static void WaitForState<TComponent>(this IRenderedComponent<TComponent>
 		/// <param name="statePredicate">The predicate to invoke after each render, which must returns <c>true</c> when the desired state has been reached.</param>
 		/// <param name="timeout">The maximum time to wait for the desired state.</param>
 		/// <exception cref="WaitForFailedException">Thrown if the <paramref name="statePredicate"/> throw an exception during invocation, or if the timeout has been reached. See the inner exception for details.</exception>
-		internal static async Task WaitForStateAsync<TComponent>(this IRenderedComponent<TComponent> renderedComponent, Func<bool> statePredicate, TimeSpan? timeout = null)
+		public static async Task WaitForStateAsync<TComponent>(this IRenderedComponent<TComponent> renderedComponent, Func<bool> statePredicate, TimeSpan? timeout = null)
 			where TComponent : IComponent
 		{
 			using var waiter = new WaitForStateHelper<TComponent>(renderedComponent, statePredicate, timeout);
-
 			await waiter.WaitTask;
 		}
 
@@ -75,7 +74,7 @@ public static void WaitForAssertion<TComponent>(this IRenderedComponent<TCompone
 
 			try
 			{
-				waiter.WaitTask.GetAwaiter().GetResult();
+				waiter.WaitTask.ConfigureAwait(false).GetAwaiter().GetResult();
 			}
 			catch (AggregateException e) when (e.InnerExceptions.Count == 1)
 			{
@@ -94,11 +93,10 @@ public static void WaitForAssertion<TComponent>(this IRenderedComponent<TCompone
 		/// <param name="timeout">The maximum time to attempt the verification.</param>
 		/// <exception cref="WaitForFailedException">Thrown if the timeout has been reached. See the inner exception to see the captured assertion exception.</exception>
 		[AssertionMethod]
-		internal static async Task WaitForAssertionAsync<TComponent>(this IRenderedComponent<TComponent> renderedComponent, Action assertion, TimeSpan? timeout = null)
+		public static async Task WaitForAssertionAsync<TComponent>(this IRenderedComponent<TComponent> renderedComponent, Action assertion, TimeSpan? timeout = null)
 			where TComponent : IComponent
 		{
 			using var waiter = new WaitForAssertionHelper<TComponent>(renderedComponent, assertion, timeout);
-
 			await waiter.WaitTask;
 		}
 }