Skip to content

Commit 5ba4ba2

Browse files
authored
Ensure deps referenced in java_test_suite make vars are passed to tests (#332)
#303 introduced a regression where if a `java_test_suite` references a dep in its jvm_flags via `$(location)` or other Make variable, it will not be present in the deps of the generated `java_test` leading to analysis errors. This PR adds an example demonstrating the issue and suggests a possible fix. Fixes #334
1 parent d09dbd6 commit 5ba4ba2

File tree

7 files changed

+1117
-262
lines changed

7 files changed

+1117
-262
lines changed

examples/tests_and_lints/MODULE.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ maven.install(
3838
"com.github.spotbugs:spotbugs:4.7.3",
3939
"com.h3xstream.findsecbugs:findsecbugs-plugin:1.12.0",
4040
"com.mebigfatguy.sb-contrib:sb-contrib:7.6.4",
41+
"org.jmockit:jmockit:1.38",
4142
],
4243
fetch_sources = True,
4344
lock_file = "//:maven_install.json",

0 commit comments

Comments
 (0)